virJSONValueObjectAddVArgs: Add check for presence of the ':' separator

Enforce that the ':' separator between the key and value is always
present.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

diff --git a/src/util/virjson.c b/src/util/virjson.c
index 26491bd6c73801a1fa3a32dbd99408b2820df67b..4aabad15ef26e59862eb33c85920b0255fcf89e6 100644 (file)
--- a/src/util/virjson.c
+++ b/src/util/virjson.c
@@ -161,9 +161,9 @@ virJSONValueObjectAddVArgs(virJSONValue *obj,
 
     while ((key = va_arg(args, char *)) != NULL) {
 
-        if (strlen(key) < 3) {
+        if (strlen(key) < 3 || key[1] != ':') {
             virReportError(VIR_ERR_INTERNAL_ERROR,
-                           _("argument key '%s' is too short, missing type prefix"),
+                           _("argument key '%s' is too short or malformed"),
                            key);
             return -1;
         }