]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
i2c: designware: Omit a variable reassignment in dw_i2c_plat_probe()
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 20 Oct 2025 10:56:39 +0000 (12:56 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Mon, 27 Oct 2025 13:17:15 +0000 (14:17 +0100)
An error code was assigned to a variable and checked accordingly.
This value was passed to a dev_err_probe() call in an if branch.
This function is documented in the way that the same value is returned.
Thus delete a redundant variable reassignment.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Anand Moon <linux.amoon@gmail.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/bec52694-c755-4d88-aa36-1d96f6d146e4@web.de
drivers/i2c/busses/i2c-designware-platdrv.c

index cff7e03dea7bb1cfc09e39abf57e1f0d7cf75662..7be99656a67db45334eccb2e3bd53ab3dc9b059b 100644 (file)
@@ -239,7 +239,7 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)
 
        ret = i2c_dw_probe_lock_support(dev);
        if (ret) {
-               ret = dev_err_probe(device, ret, "failed to probe lock support\n");
+               dev_err_probe(device, ret, "failed to probe lock support\n");
                goto exit_reset;
        }