]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
storage_file: Declare virStorageSourceParseRBDColonString only in one header
authorMichal Privoznik <mprivozn@redhat.com>
Fri, 7 Jan 2022 13:10:03 +0000 (14:10 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 17 Jan 2022 08:53:44 +0000 (09:53 +0100)
The virStorageSourceParseRBDColonString() function is declared in
src/storage_file/storage_source.h and
src/storage_file/storage_source_backingstore.h but implemented
only in the .c that corresponds to the latter header file.
Therefore, drop declaration from storage_source.h as the function
is not implemented in its corresponding .c file.

Leftover from: 2d29a3a9d86b5f95a859888283e6caa98593b1d2
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/libxl/xen_xl.c
src/storage_file/storage_source.h
src/storage_file/storage_source_backingstore.h

index 7604e3d5349903c053cb1e61ee2cc98c6954f8ae..94268fb76d47203e8ab7a468f4877a2e6a9f66ea 100644 (file)
@@ -30,6 +30,7 @@
 #include "viralloc.h"
 #include "virstring.h"
 #include "storage_source.h"
+#include "storage_source_backingstore.h"
 #include "xen_xl.h"
 #include "libxl_capabilities.h"
 #include "libxl_conf.h"
index 5aaf4c356ab835f5d8fd4297aad927975faa9d68..0ae06f4e7d1cd3a8d388e2751867c7075b9a5b56 100644 (file)
@@ -66,11 +66,6 @@ int
 virStorageSourceNewFromBacking(virStorageSource *parent,
                                virStorageSource **backing);
 
-int
-virStorageSourceParseRBDColonString(const char *rbdstr,
-                                    virStorageSource *src)
-    ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
-
 int
 virStorageSourceGetRelativeBackingPath(virStorageSource *top,
                                        virStorageSource *base,
index f5ec8e9154bceea3759dc3d41d864657a2f0d5c6..e7e2a58eb9c720e2681569509cbf2f2a2d7db0d7 100644 (file)
@@ -29,7 +29,8 @@ virStorageSourceParseBackingURI(virStorageSource *src,
 
 int
 virStorageSourceParseRBDColonString(const char *rbdstr,
-                                    virStorageSource *src);
+                                    virStorageSource *src)
+    ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
 
 int
 virStorageSourceParseBackingColon(virStorageSource *src,