]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: skbuff: Drop unused @skb
authorMichal Luczaj <mhal@rbox.co>
Wed, 2 Jul 2025 13:38:11 +0000 (15:38 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 8 Jul 2025 15:37:22 +0000 (08:37 -0700)
Since its introduction in commit ce098da1497c ("skbuff: Introduce
slab_build_skb()"), __slab_build_skb() never used the @skb argument. Remove
it and adapt both callers.

No functional change intended.

Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Michal Luczaj <mhal@rbox.co>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/skbuff.c

index a34fe37cf7a508c8380e35522d9cde266aa440f9..74ced6aebc70e3dd1656c2fa28b8b89be6e227b8 100644 (file)
@@ -384,8 +384,7 @@ static inline void __finalize_skb_around(struct sk_buff *skb, void *data,
        skb_set_kcov_handle(skb, kcov_common_handle());
 }
 
-static inline void *__slab_build_skb(struct sk_buff *skb, void *data,
-                                    unsigned int *size)
+static inline void *__slab_build_skb(void *data, unsigned int *size)
 {
        void *resized;
 
@@ -418,7 +417,7 @@ struct sk_buff *slab_build_skb(void *data)
                return NULL;
 
        memset(skb, 0, offsetof(struct sk_buff, tail));
-       data = __slab_build_skb(skb, data, &size);
+       data = __slab_build_skb(data, &size);
        __finalize_skb_around(skb, data, size);
 
        return skb;
@@ -435,7 +434,7 @@ static void __build_skb_around(struct sk_buff *skb, void *data,
         * using slab buffer should use slab_build_skb() instead.
         */
        if (WARN_ONCE(size == 0, "Use slab_build_skb() instead"))
-               data = __slab_build_skb(skb, data, &size);
+               data = __slab_build_skb(data, &size);
 
        __finalize_skb_around(skb, data, size);
 }