]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ext2: guard reservation window dump with EXT2FS_DEBUG
authorMilos Nikic <nikic.milos@gmail.com>
Sat, 7 Feb 2026 02:29:20 +0000 (18:29 -0800)
committerJan Kara <jack@suse.cz>
Fri, 27 Feb 2026 11:16:07 +0000 (12:16 +0100)
The function __rsv_window_dump() is a heavyweight debug tool that walks
the reservation red-black tree. It is currently guarded by #if 1,
forcing it to be compiled into all kernels, even production ones.

Match the rest of the file by guarding it with #ifdef EXT2FS_DEBUG,
so it is only included when explicit debugging is enabled.

This removes the unused function code from standard builds.

Signed-off-by: Milos Nikic <nikic.milos@gmail.com>
Link: https://patch.msgid.link/20260207022920.258247-1-nikic.milos@gmail.com
Signed-off-by: Jan Kara <jack@suse.cz>
fs/ext2/balloc.c

index 007eee794bd1748e9d5abbb9b44791017de62d58..adf0f31fbddd16eec8a819a93e485c8f50c37e4b 100644 (file)
@@ -201,7 +201,7 @@ static void group_adjust_blocks(struct super_block *sb, int group_no,
  * windows(start, end). Otherwise, it will only print out the "bad" windows,
  * those windows that overlap with their immediate neighbors.
  */
-#if 1
+#ifdef EXT2FS_DEBUG
 static void __rsv_window_dump(struct rb_root *root, int verbose,
                              const char *fn)
 {
@@ -248,7 +248,7 @@ restart:
        __rsv_window_dump((root), (verbose), __func__)
 #else
 #define rsv_window_dump(root, verbose) do {} while (0)
-#endif
+#endif /* EXT2FS_DEBUG */
 
 /**
  * goal_in_my_reservation()