]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
firmware: arm_scmi: Fix up turbo frequencies selection
authorSibi Sankar <quic_sibis@quicinc.com>
Wed, 14 May 2025 21:47:19 +0000 (03:17 +0530)
committerSudeep Holla <sudeep.holla@arm.com>
Mon, 23 Jun 2025 13:36:17 +0000 (14:36 +0100)
Sustained frequency when greater than or equal to 4Ghz on 64-bit devices
currently result in marking all frequencies as turbo. Address the turbo
frequency selection bug by fixing the truncation.

Fixes: a897575e79d7 ("firmware: arm_scmi: Add support for marking certain frequencies as turbo")
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
Message-Id: <20250514214719.203607-1-quic_sibis@quicinc.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/perf.c

index c7e5a34b254bf4e9c51c7be56803b6d851f0e1d6..683fd9b85c5ce2c2a836de50139a136e8c310580 100644 (file)
@@ -892,7 +892,7 @@ static int scmi_dvfs_device_opps_add(const struct scmi_protocol_handle *ph,
                        freq = dom->opp[idx].indicative_freq * dom->mult_factor;
 
                /* All OPPs above the sustained frequency are treated as turbo */
-               data.turbo = freq > dom->sustained_freq_khz * 1000;
+               data.turbo = freq > dom->sustained_freq_khz * 1000UL;
 
                data.level = dom->opp[idx].perf;
                data.freq = freq;