Bug 300006: "cookies need value" error code when a query returns an empty result.

Patch By Marc Schumann <wurblzap@gmail.com> r=glob, a=justdave

diff --git a/buglist.cgi b/buglist.cgi
index 8654dd0be158553b1825aa80aa1882a39cf8a89d..d42ba67af4d37b5e7550dae6c6e16f029320a597 100755 (executable)
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -954,7 +954,10 @@ if ($format->{'extension'} eq "html") {
     }
     my $bugids = join(":", @bugidlist);
     # See also Bug 111999
-    if (length($bugids) < 4000) {
+    if (length($bugids) == 0) {
+        $cgi->remove_cookie('BUGLIST');
+    }
+    elsif (length($bugids) < 4000) {
         $cgi->send_cookie(-name => 'BUGLIST',
                           -value => $bugids,
                           -expires => 'Fri, 01-Jan-2038 00:00:00 GMT');

diff --git a/colchange.cgi b/colchange.cgi
index 866c3d1855beca6f462aa770ffdedfe120288d73..7db41fa4c2568cc6cb4a0e7bf3a36222fc44d63c 100755 (executable)
--- a/colchange.cgi
+++ b/colchange.cgi
@@ -97,9 +97,14 @@ if (defined $cgi->param('rememberedquery')) {
     my $list = join(" ", @collist);
     my $urlbase = Param("urlbase");
 
-    $cgi->send_cookie(-name => 'COLUMNLIST',
-                      -value => $list,
-                      -expires => 'Fri, 01-Jan-2038 00:00:00 GMT');
+    if ($list) {
+        $cgi->send_cookie(-name => 'COLUMNLIST',
+                          -value => $list,
+                          -expires => 'Fri, 01-Jan-2038 00:00:00 GMT');
+    }
+    else {
+        $cgi->remove_cookie('COLUMNLIST');
+    }
     if ($splitheader) {
         $cgi->send_cookie(-name => 'SPLITHEADER',
                           -value => $splitheader,