]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
backlight: sky81452-backlight: Fix refcount imbalance on error
authordinghao.liu@zju.edu.cn <dinghao.liu@zju.edu.cn>
Thu, 20 Aug 2020 06:38:17 +0000 (14:38 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 09:07:32 +0000 (10:07 +0100)
[ Upstream commit b7a4f80bc316a56d6ec8750e93e66f42431ed960 ]

When of_property_read_u32_array() returns an error code, a
pairing refcount decrement is needed to keep np's refcount
balanced.

Fixes: f705806c9f355 ("backlight: Add support Skyworks SKY81452 backlight driver")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/video/backlight/sky81452-backlight.c

index 2355f00f577327730221e488abeb742a632a6dea..1f6301375fd330f3eabe3d5e842e53e79b767561 100644 (file)
@@ -196,6 +196,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
                                        num_entry);
                if (ret < 0) {
                        dev_err(dev, "led-sources node is invalid.\n");
+                       of_node_put(np);
                        return ERR_PTR(-EINVAL);
                }