detect: remove code writing unused values

Coveridy ID 1546822 1546823 and 1546824

diff --git a/src/detect-engine-address.c b/src/detect-engine-address.c
index 287517194735cc1f330d570534e3b4d64f1a66d0..ac10e142dedc737efd7a99d0962de6df50a6cd23 100644 (file)
--- a/src/detect-engine-address.c
+++ b/src/detect-engine-address.c
@@ -1289,7 +1289,6 @@ int DetectAddressTestConfVars(void)
         }
 
         DetectAddressHeadFree(gh);
-        gh = NULL;
         DetectAddressHeadFree(ghn);
         ghn = NULL;
     }

diff --git a/src/detect-engine-build.c b/src/detect-engine-build.c
index e957b50bdb071c7ca3b86910277dba521d9c5111..8b76212719831638199dba2575c60a9fbc9f4e0e 100644 (file)
--- a/src/detect-engine-build.c
+++ b/src/detect-engine-build.c
@@ -1645,8 +1645,6 @@ int CreateGroupedPortList(DetectEngineCtx *de_ctx, DetectPort *port_list, Detect
             /* when a group's sigs are added to the joingr, we can free it */
             gr->next = NULL;
             DetectPortFree(de_ctx, gr);
-            gr = NULL;
-
         /* append */
         } else {
             gr->next = NULL;

diff --git a/src/util-threshold-config.c b/src/util-threshold-config.c
index 74e58fbc8c7622831fc080ffa8aad3fc835fab35..5d762a8f709182d7efb4990c12f432f8e73bd8c3 100644 (file)
--- a/src/util-threshold-config.c
+++ b/src/util-threshold-config.c
@@ -510,7 +510,6 @@ static int SetupThresholdRule(DetectEngineCtx *de_ctx, uint32_t id, uint32_t gid
                 if (sm != NULL) {
                     SigMatchRemoveSMFromList(s, sm, DETECT_SM_LIST_THRESHOLD);
                     SigMatchFree(de_ctx, sm);
-                    sm = NULL;
                 }
             }