]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
[pre-commit] Stop using deprecated language script
authorTom de Vries <tdevries@suse.de>
Tue, 16 Jun 2026 18:34:14 +0000 (20:34 +0200)
committerTom de Vries <tdevries@suse.de>
Tue, 16 Jun 2026 18:34:14 +0000 (20:34 +0200)
In v4.4.0, pre-commit renamed language script to unsupported_script.

The rename was done to stress that pre-commit doesn't provide an environment
for the script to run in [1].

The language script is now a deprecated alias for unsupported_script, and the
plan seems to be to initially produce a deprecation warning, and eventually
remove support for the alias completely.

Start using the new name: unsupported_script.

Furthermore, the check-include-guards hook uses language python, and indeed it
uses a python script, but it doesn't really need a virtual environment.  It
imports modules fnmatch, re, sys and typing, all of which are available in
python 3.10 and later, which is the environment pre-commit itself requires
(because we require pre-commit v4.5.1 or later, and pre-commit requires python
3.10 since v4.4.0).  So while we're at it, use unsupported_script for this
hook as well, reducing the amount of environments pre-commit has to manage.

Tested using "pre-commit run --all-files" with python 3.10, as well as 3.13.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
[1] https://github.com/pre-commit/pre-commit/pull/3577

.pre-commit-config.yaml

index 3c2a27acb11d9c5e1d3200c88d2b5acca0adb074..351b9f6933f0ec1bd840c098bc5b598876f9d9e0 100644 (file)
@@ -84,7 +84,7 @@ repos:
     hooks:
     - id: check-include-guards
       name: check-include-guards
-      language: python
+      language: unsupported_script
       entry: gdb/check-include-guards.py
       # All gdb header files, but not headers in the test suite.
       files: '^(gdb(support|server)?)/.*\.h$'
@@ -100,7 +100,7 @@ repos:
       stages: [pre-commit]
     - id: check-whitespace
       name: check-whitespace
-      language: script
+      language: unsupported_script
       entry: gdb/contrib/check-whitespace-pre-commit.py
       files: '^(gdb(support|server)?)/.*$'
       pass_filenames: true
@@ -114,7 +114,7 @@ repos:
       require_serial: true
     - id: check-file-mode
       name: check-file-mode
-      language: script
+      language: unsupported_script
       entry: gdb/contrib/check-file-mode.sh
       files: '^(gdb|gdbserver|gdbsupport)/.*$'
   - repo: https://github.com/nmoroze/tclint