]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
wifi: brcmsmac: add gain range check to wlc_phy_iqcal_gainparams_nphy()
authorDmitry Antipov <dmantipov@yandex.ru>
Tue, 10 Dec 2024 07:04:41 +0000 (10:04 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Feb 2025 12:49:31 +0000 (13:49 +0100)
[ Upstream commit 3f4a0948c3524ae50f166dbc6572a3296b014e62 ]

In 'wlc_phy_iqcal_gainparams_nphy()', add gain range check to WARN()
instead of possible out-of-bounds 'tbl_iqcal_gainparams_nphy' access.
Compile tested only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20241210070441.836362-1-dmantipov@yandex.ru
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c

index 8580a275478918f9e140d378b20e6c84f4325dd6..42e7bc67e9143e475bb4abe4e24230fe7ab19db2 100644 (file)
@@ -23427,6 +23427,9 @@ wlc_phy_iqcal_gainparams_nphy(struct brcms_phy *pi, u16 core_no,
                                break;
                }
 
+               if (WARN_ON(k == NPHY_IQCAL_NUMGAINS))
+                       return;
+
                params->txgm = tbl_iqcal_gainparams_nphy[band_idx][k][1];
                params->pga = tbl_iqcal_gainparams_nphy[band_idx][k][2];
                params->pad = tbl_iqcal_gainparams_nphy[band_idx][k][3];