]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
kernel: trace: preemptirq_delay_test: use offstack cpu mask
authorArnd Bergmann <arnd@arndb.de>
Fri, 20 Jun 2025 11:12:12 +0000 (13:12 +0200)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 8 Jul 2025 22:17:38 +0000 (18:17 -0400)
A CPU mask on the stack is broken for large values of CONFIG_NR_CPUS:

kernel/trace/preemptirq_delay_test.c: In function ‘preemptirq_delay_run’:
kernel/trace/preemptirq_delay_test.c:143:1: error: the frame size of 8512 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]

Fall back to dynamic allocation here.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Song Chen <chensong_2000@189.cn>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://lore.kernel.org/20250620111215.3365305-1-arnd@kernel.org
Fixes: 4b9091e1c194 ("kernel: trace: preemptirq_delay_test: add cpu affinity")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/preemptirq_delay_test.c

index 314ffc143039c53da1c0612448901a8104cdd3d5..acb0c971a4082ad050c4362cd651b4bbbb8538b0 100644 (file)
@@ -117,12 +117,15 @@ static int preemptirq_delay_run(void *data)
 {
        int i;
        int s = MIN(burst_size, NR_TEST_FUNCS);
-       struct cpumask cpu_mask;
+       cpumask_var_t cpu_mask;
+
+       if (!alloc_cpumask_var(&cpu_mask, GFP_KERNEL))
+               return -ENOMEM;
 
        if (cpu_affinity > -1) {
-               cpumask_clear(&cpu_mask);
-               cpumask_set_cpu(cpu_affinity, &cpu_mask);
-               if (set_cpus_allowed_ptr(current, &cpu_mask))
+               cpumask_clear(cpu_mask);
+               cpumask_set_cpu(cpu_affinity, cpu_mask);
+               if (set_cpus_allowed_ptr(current, cpu_mask))
                        pr_err("cpu_affinity:%d, failed\n", cpu_affinity);
        }
 
@@ -139,6 +142,8 @@ static int preemptirq_delay_run(void *data)
 
        __set_current_state(TASK_RUNNING);
 
+       free_cpumask_var(cpu_mask);
+
        return 0;
 }