threads: cleaner code with one instruction per line

As reported by Shchelk

diff --git a/src/tm-threads.c b/src/tm-threads.c
index 80915f33dd2003bd0722c9789ea7895112ff3f7a..7bd6cfa8bcb519c3c524e6f6142914a0b1119067 100644 (file)
--- a/src/tm-threads.c
+++ b/src/tm-threads.c
@@ -175,9 +175,9 @@ static int TmThreadTimeoutLoop(ThreadVars *tv, TmSlot *s)
                 Packet *p = PacketDequeue(tv->stream_pq);
                 SCMutexUnlock(&tv->stream_pq->mutex_q);
                 if (likely(p)) {
-                    if ((r = TmThreadsSlotProcessPkt(tv, fw_slot, p) != TM_ECODE_OK)) {
-                        if (r == TM_ECODE_FAILED)
-                            break;
+                    r = TmThreadsSlotProcessPkt(tv, fw_slot, p);
+                    if (r == TM_ECODE_FAILED) {
+                        break;
                     }
                 }
             }