]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[#1250] Fixed sporadic UT failures
authorMarcin Siodelski <marcin@isc.org>
Thu, 10 Dec 2020 08:11:20 +0000 (09:11 +0100)
committerMarcin Siodelski <marcin@isc.org>
Thu, 10 Dec 2020 08:11:20 +0000 (09:11 +0100)
The tests were performing strict cltt comparison now the comparison is
not strict to avoid acceptable off by 1 errors.

src/bin/dhcp6/tests/rebind_unittest.cc
src/bin/dhcp6/tests/renew_unittest.cc

index 8fa183040d25fac3d4b1876dc3966df362452e35..a9d59dc3e0d0c65920f836904ff740a04ac1ba86 100644 (file)
@@ -945,7 +945,7 @@ TEST_F(RebindTest, requestPrefixInRebind) {
     EXPECT_EQ(STATUS_Success, client.getStatusCode(1234));
 
     // The lease should have been rebound.
-    EXPECT_EQ(1000, leases_client_na_rebound[0].cltt_ - leases_client_na[0].cltt_);
+    EXPECT_GE(leases_client_na_rebound[0].cltt_ - leases_client_na[0].cltt_, 1000);
 
     // The client should now also acquire a PD lease.
     leases_client_pd = client.getLeasesByType(Lease::TYPE_PD);
index 50d92cc20ce30dc58c3b6637fead846852710b67..f8d2c32d060cc549f024b17c91fa86ba727745cc 100644 (file)
@@ -376,8 +376,8 @@ TEST_F(RenewTest, renewWithExcludedPrefix) {
     EXPECT_EQ(STATUS_Success, client.getStatusCode(pd_iaid_));
 
     // The leases should have been renewed.
-    EXPECT_EQ(1000, leases_client_na_renewed[0].cltt_ - leases_client_na[0].cltt_);
-    EXPECT_EQ(1000, leases_client_pd_renewed[0].cltt_ - leases_client_pd[0].cltt_);
+    EXPECT_GE(leases_client_na_renewed[0].cltt_ - leases_client_na[0].cltt_, 1000);
+    EXPECT_GE(leases_client_pd_renewed[0].cltt_ - leases_client_pd[0].cltt_, 1000);
 
     // This time, the Prefix Exclude option should be included.
     option = client.getContext().response_->getOption(D6O_IA_PD);