]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
c++: explicit(bool) malfunction with dependent expression [PR95066]
authorMarek Polacek <polacek@redhat.com>
Thu, 11 Jun 2020 20:33:13 +0000 (16:33 -0400)
committerMarek Polacek <polacek@redhat.com>
Thu, 11 Jun 2020 20:33:13 +0000 (16:33 -0400)
I forgot to set DECL_HAS_DEPENDENT_EXPLICIT_SPEC_P when merging two
function declarations and as a sad consequence, we never tsubsted
the dependent explicit-specifier in tsubst_function_decl, leading to
disregarding the explicit-specifier altogether, and wrongly accepting
this test.

PR c++/95066
* decl.c (duplicate_decls): Set DECL_HAS_DEPENDENT_EXPLICIT_SPEC_P.

* g++.dg/cpp2a/explicit16.C: New test.

gcc/cp/decl.c
gcc/testsuite/g++.dg/cpp2a/explicit16.C [new file with mode: 0644]

index ae8fd32d83b9110704fa2183ce32677e5adc5f1d..4199778fe4ebfc4c0410e5af1fdd274cf7b8b025 100644 (file)
@@ -2035,6 +2035,8 @@ duplicate_decls (tree newdecl, tree olddecl, bool newdecl_is_friend)
       DECL_FINAL_P (newdecl) |= DECL_FINAL_P (olddecl);
       DECL_OVERRIDE_P (newdecl) |= DECL_OVERRIDE_P (olddecl);
       DECL_THIS_STATIC (newdecl) |= DECL_THIS_STATIC (olddecl);
+      DECL_HAS_DEPENDENT_EXPLICIT_SPEC_P (newdecl)
+       |= DECL_HAS_DEPENDENT_EXPLICIT_SPEC_P (olddecl);
       if (DECL_OVERLOADED_OPERATOR_P (olddecl))
        DECL_OVERLOADED_OPERATOR_CODE_RAW (newdecl)
          = DECL_OVERLOADED_OPERATOR_CODE_RAW (olddecl);
diff --git a/gcc/testsuite/g++.dg/cpp2a/explicit16.C b/gcc/testsuite/g++.dg/cpp2a/explicit16.C
new file mode 100644 (file)
index 0000000..9d95b0d
--- /dev/null
@@ -0,0 +1,21 @@
+// PR c++/95066 - explicit malfunction with dependent expression.
+// { dg-do compile { target c++2a } }
+
+template <typename T>
+struct Foo {
+  template <typename U>
+  explicit(static_cast<U>(true)) operator Foo<U>();
+};
+
+template <typename T>
+template <typename U>
+Foo<T>::operator Foo<U>() {
+  return {};
+}
+
+int
+main ()
+{
+  Foo<float> a;
+  Foo<int> b = a; // { dg-error "conversion" }
+}