Author: Tim Brown <squid-cache@machine.org.uk>

Bug 2595: Out of bounds memory write due to off by one

diff --git a/helpers/negotiate_auth/squid_kerb_auth/squid_kerb_auth.c b/helpers/negotiate_auth/squid_kerb_auth/squid_kerb_auth.c
index cad7e6f1a161f383fbf74f656b83bd1c880a7ae2..13adb43f1fa2fcbc26a6dcfcbabd9e992255ab2f 100644 (file)
--- a/helpers/negotiate_auth/squid_kerb_auth/squid_kerb_auth.c
+++ b/helpers/negotiate_auth/squid_kerb_auth/squid_kerb_auth.c
@@ -115,7 +115,7 @@ char *gethost_name(void) {
   }
 
   freeaddrinfo(hres);
-  hostname[MAXHOSTNAMELEN]='\0';
+  hostname[MAXHOSTNAMELEN-1]='\0';
   return(strdup(hostname));
 }