]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe: Drop skip_mtcfg descriptor flag
authorMatt Roper <matthew.d.roper@intel.com>
Thu, 16 Apr 2026 21:17:09 +0000 (14:17 -0700)
committerMatt Roper <matthew.d.roper@intel.com>
Fri, 17 Apr 2026 15:05:54 +0000 (08:05 -0700)
The skip_mtcfg descriptor flag is unused and expected to remain that
way.  Drop it.

Single-tile platforms are already identified by a zero/unset value for
max_remote_tiles and don't need/use this flag to avoid trying to read
out multi-tile configuration.  PVC is currently the only multi-tile
platform, and PVC uses MTCFG so this flag is not set.  The current
expectation is that if/when future multi-tile platforms show up, they
will also use the MTCFG register in the same manner as PVC, meaning that
they won't have any need to set 'skip_mtcfg' either.

Even if a future platform does change how multi-tile configuration gets
probed (e.g., using some different register), simply doing an early return
from xe_info_probe_tile_count() would probably not be the correct logic
to handle that anyway.

Bspec: 53146
Reviewed-by: Xin Wang <x.wang@intel.com>
Link: https://patch.msgid.link/20260416-no-skip-mtcfg-v1-1-c8ea26d81530@intel.com
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
drivers/gpu/drm/xe/xe_device_types.h
drivers/gpu/drm/xe/xe_pci.c
drivers/gpu/drm/xe/xe_pci_types.h

index 2ebe33a0dc074b38a1813a17f16d99a9506aaf23..e9e11bb1c65ff34a2f68ca6395f7172b4974ce2b 100644 (file)
@@ -218,8 +218,6 @@ struct xe_device {
                u8 probe_display:1;
                /** @info.skip_guc_pc: Skip GuC based PM feature init */
                u8 skip_guc_pc:1;
-               /** @info.skip_mtcfg: skip Multi-Tile configuration from MTCFG register */
-               u8 skip_mtcfg:1;
                /** @info.skip_pcode: skip access to PCODE uC */
                u8 skip_pcode:1;
                /** @info.needs_shared_vf_gt_wq: needs shared GT WQ on VF */
index b1b89d09e42bb939c9c935bb53d657351616bbe2..41435f84aeb22901c8c5febf854fa79d6da5a094 100644 (file)
@@ -767,7 +767,6 @@ static int xe_info_init_early(struct xe_device *xe,
                desc->has_sriov;
        xe->info.has_sysctrl = desc->has_sysctrl;
        xe->info.skip_guc_pc = desc->skip_guc_pc;
-       xe->info.skip_mtcfg = desc->skip_mtcfg;
        xe->info.skip_pcode = desc->skip_pcode;
        xe->info.needs_scratch = desc->needs_scratch;
        xe->info.needs_shared_vf_gt_wq = desc->needs_shared_vf_gt_wq;
@@ -809,9 +808,6 @@ static void xe_info_probe_tile_count(struct xe_device *xe)
        if (xe->info.tile_count == 1)
                return;
 
-       if (xe->info.skip_mtcfg)
-               return;
-
        mmio = xe_root_tile_mmio(xe);
 
        /*
index 08386c5eca27206b22c351d7e6344bc7fa2ca26d..5b85e2c24b7b2874192b9de89cbead8346688e99 100644 (file)
@@ -60,7 +60,6 @@ struct xe_device_desc {
        u8 has_sysctrl:1;
        u8 needs_scratch:1;
        u8 skip_guc_pc:1;
-       u8 skip_mtcfg:1;
        u8 skip_pcode:1;
        u8 needs_shared_vf_gt_wq:1;
 };