]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
USB: typec: fix const issue in typec_match()
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 May 2025 13:35:24 +0000 (15:35 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 May 2025 10:36:40 +0000 (12:36 +0200)
typec_match() takes a const pointer, and then decides to cast it away
into a non-const one, which is not a good thing to do overall.  Fix this
up by properly setting the pointers to be const to preserve that
attribute.

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/2025052126-scholar-stainless-ad55@gregkh
Fixes: d69d80484598 ("driver core: have match() callback in struct bus_type take a const *")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/bus.c

index ae90688d23e400d08f895d2744bd68c89edc1f21..a884cec9ab7e88ae2a9f971121470119a2584bff 100644 (file)
@@ -449,7 +449,7 @@ ATTRIBUTE_GROUPS(typec);
 
 static int typec_match(struct device *dev, const struct device_driver *driver)
 {
-       struct typec_altmode_driver *drv = to_altmode_driver(driver);
+       const struct typec_altmode_driver *drv = to_altmode_driver(driver);
        struct typec_altmode *altmode = to_typec_altmode(dev);
        const struct typec_device_id *id;