codegen: Deprecate implicit copy of arrays, use explicit copy method

https://bugzilla.gnome.org/show_bug.cgi?id=650663

diff --git a/codegen/valaccodebasemodule.vala b/codegen/valaccodebasemodule.vala
index 9f02b8c77894e30c65cddf0ac5050bf61637c4b0..3de943864a9c9c7d9f4d3829d23ba53dc54bbecd 100644 (file)
--- a/codegen/valaccodebasemodule.vala
+++ b/codegen/valaccodebasemodule.vala
@@ -5876,6 +5876,13 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
                                return result;
                        }
                        result = copy;
+
+                       // implicit array copying is deprecated, but allow it for internal codegen usage
+                       var prop_acc = node as PropertyAccessor;
+                       if ((prop_acc != null && !prop_acc.automatic_body)
+                           && result.value_type is ArrayType) {
+                               Report.deprecated (node.source_reference, "implicit copy of array is deprecated, explicitly invoke the copy method instead");
+                       }
                }
 
                return result;