]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/msm/hdmi: Avoid double error print on msm_hdmi_get_phy() failure
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Wed, 11 Mar 2026 20:17:26 +0000 (21:17 +0100)
committerDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Wed, 25 Mar 2026 06:06:09 +0000 (08:06 +0200)
msm_hdmi_get_phy() already prints error messages on each error path
using dev_err_probe(), so final DRM_DEV_ERROR() would duplicate it and
possibly flood the dmesg on probe deferrals.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/711168/
Link: https://lore.kernel.org/r/20260311-drm-msm-hdmi-cleanup-v1-2-c5535245f6de@oss.qualcomm.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
drivers/gpu/drm/msm/hdmi/hdmi.c

index 09fda95310804a2391b4a0f10f3d83605f9c553c..6e31db76392393580b0298dd8e1068b6b4fd77fc 100644 (file)
@@ -358,10 +358,8 @@ static int msm_hdmi_dev_probe(struct platform_device *pdev)
                gpiod_set_consumer_name(hdmi->hpd_gpiod, "HDMI_HPD");
 
        ret = msm_hdmi_get_phy(hdmi);
-       if (ret) {
-               DRM_DEV_ERROR(&pdev->dev, "failed to get phy\n");
+       if (ret)
                return ret;
-       }
 
        ret = devm_pm_runtime_enable(&pdev->dev);
        if (ret)