]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
AP MLD: Remove common elements from per STA profile
authorPavithra Ganesan <quic_pavigane@quicinc.com>
Mon, 11 Nov 2024 03:42:21 +0000 (09:12 +0530)
committerJouni Malinen <j@w1.fi>
Wed, 27 Nov 2024 17:26:19 +0000 (19:26 +0200)
Even when an element and its contents in the reported link match those
in the reporting link, the element was still added to the per-STA
profile of the reported link. This occurs because the parsed bitmap is
not updated when a match is found, resulting in the element being added
later. This results in per STA profile carrying extra information which
it should not.

Fix this issue by updating the parsed element ID bitmap accordingly.

Fixes: b5359d01ed55 ("AP MLD: Intersect per STA profile with the reporting BSS")
Signed-off-by: Pavithra Ganesan <quic_pavigane@quicinc.com>
Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
src/ap/beacon.c

index 2e3d9046698a4f8d8990e4743302fda3dd64e742..c91d27219aec9f6a18483ce56283607d9120f9d6 100644 (file)
@@ -2909,7 +2909,15 @@ static size_t hostapd_add_sta_profile(struct ieee80211_mgmt *link_fdata,
                                        is_identical_vendor_ies = true;
                                        num_own_elem_vendor_ies++;
                                }
-                               continue;
+
+                               /* Update the parsed EIDs bitmap */
+                               if (is_ext)
+                                       parsed_ext_eid_bmap[own_eid / 8] |=
+                                               BIT(own_eid % 8);
+                               else
+                                       parsed_eid_bmap[own_eid / 8] |=
+                                               BIT(own_eid % 8);
+                               break;
                        }
 
                        /* No need to include this non-matching Vendor Specific