]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soundwire: Correct some property names
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Tue, 24 Jun 2025 12:55:07 +0000 (13:55 +0100)
committerVinod Koul <vkoul@kernel.org>
Thu, 26 Jun 2025 20:51:23 +0000 (13:51 -0700)
The DisCo properties should be mipi-sdw-paging-supported and
mipi-sdw-bank-delay-supported, with an 'ed' on the end. Correct the
property names used in sdw_slave_read_prop().

The internal flag bank_delay_support is currently unimplemented, so that
being read wrong does not currently affect anything. The two existing
users for this helper and the paging_support flag rt1320-sdw.c and
rt721-sdca-sdw.c both manually set the flag in their slave properties,
thus are not affected by this bug either.

Fixes: 56d4fe31af77 ("soundwire: Add MIPI DisCo property helpers")
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20250624125507.2866346-1-ckeepax@opensource.cirrus.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/mipi_disco.c

index 65afb28ef8fab1f8f15d41add587459161bde142..c69b78cd0b62097b2af55b2f13fbc7da7eed6351 100644 (file)
@@ -451,10 +451,10 @@ int sdw_slave_read_prop(struct sdw_slave *slave)
                        "mipi-sdw-highPHY-capable");
 
        prop->paging_support = mipi_device_property_read_bool(dev,
-                       "mipi-sdw-paging-support");
+                       "mipi-sdw-paging-supported");
 
        prop->bank_delay_support = mipi_device_property_read_bool(dev,
-                       "mipi-sdw-bank-delay-support");
+                       "mipi-sdw-bank-delay-supported");
 
        device_property_read_u32(dev,
                        "mipi-sdw-port15-read-behavior", &prop->p15_behave);