]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
ssl: fix compiler warning
authorPhilippe Antoine <pantoine@oisf.net>
Tue, 27 Sep 2022 13:47:06 +0000 (15:47 +0200)
committerVictor Julien <vjulien@oisf.net>
Thu, 29 Sep 2022 09:19:39 +0000 (11:19 +0200)
implicit conversion loses integer precision: 'int' to 'uint16_t'
because C shifts << translates automatically to signed integers

src/app-layer-ssl.c

index 9a1a30c3b18783456f5ed621c5ae22c68cfa083e..b8cecdcb77ef408a7e6d96cc94b92259e48ef404 100644 (file)
@@ -2106,7 +2106,7 @@ static struct SSLDecoderResult SSLv2Decode(uint8_t direction, SSLState *ssl_stat
             ssl_state->current_flags = SSL_AL_FLAG_STATE_CLIENT_HELLO;
             ssl_state->current_flags |= SSL_AL_FLAG_SSL_CLIENT_HS;
 
-            const uint16_t version = input[0] << 8 | input[1];
+            const uint16_t version = (uint16_t)(input[0] << 8) | input[1];
             SCLogDebug("SSLv2: version %04x", version);
             ssl_state->curr_connp->version = version;
             uint16_t session_id_length = (input[5]) | (uint16_t)(input[4] << 8);