]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
remove non-working mssql description_encoding param
authorMike Bayer <mike_mp@zzzcomputing.com>
Tue, 11 Jan 2022 14:46:19 +0000 (09:46 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Tue, 11 Jan 2022 14:46:19 +0000 (09:46 -0500)
the description_encoding concept has been fully
removed in 2.0, but this logic was plainly broken
in any case.   The same non-working logic exists in
1.4 as well, where description_encoding as a concept
is not removed, though it is likely that there are no
real-world use cases for it.

Change-Id: Icaf47f4740e3f57063b614a1d4136e0d89f40621

lib/sqlalchemy/dialects/mssql/pyodbc.py

index b629aadd32d70d65a5bf29ab31a11332f84860ee..3af083a6aed30f00338469ab3a4afdc78a743804 100644 (file)
@@ -512,11 +512,7 @@ class MSDialect_pyodbc(PyODBCConnector, MSDialect):
         },
     )
 
-    def __init__(
-        self, description_encoding=None, fast_executemany=False, **params
-    ):
-        if "description_encoding" in params:
-            self.description_encoding = params.pop("description_encoding")
+    def __init__(self, fast_executemany=False, **params):
         super(MSDialect_pyodbc, self).__init__(**params)
         self.use_scope_identity = (
             self.use_scope_identity