Strings need to be copied to the to_cast box first

diff --git a/src/lib/redis/redis.c b/src/lib/redis/redis.c
index 377a5ed1d6f72aa0ace498e15fb22f902b16be01..76881a8224396b29f3e22d15a3e8cb517e3d7d10 100644 (file)
--- a/src/lib/redis/redis.c
+++ b/src/lib/redis/redis.c
@@ -278,9 +278,9 @@ int fr_redis_reply_to_value_box(TALLOC_CTX *ctx, fr_value_box_t *out, redisReply
        case REDIS_REPLY_STRING:
        case REDIS_REPLY_STATUS:
                if (shallow) {
-                       fr_value_box_bstrndup_shallow(out, NULL, reply->str, reply->len, true);
+                       fr_value_box_bstrndup_shallow(to_cast, NULL, reply->str, reply->len, true);
                } else {
-                       if (fr_value_box_bstrndup(ctx, out, NULL, reply->str, reply->len, true) < 0) return -1;
+                       if (fr_value_box_bstrndup(ctx, to_cast, NULL, reply->str, reply->len, true) < 0) return -1;
                }
                break;