]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mtd: rawnand: arasan: Fix missing de-registration of NAND
authorMaciej Andrzejewski <maciej.andrzejewski@m-works.net>
Mon, 2 Dec 2024 18:58:36 +0000 (19:58 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Jan 2025 09:30:49 +0000 (10:30 +0100)
commit 11e6831fd81468cf48155b9b3c11295c391da723 upstream.

The NAND chip-selects are registered for the Arasan driver during
initialization but are not de-registered when the driver is unloaded. As a
result, if the driver is loaded again, the chip-selects remain registered
and busy, making them unavailable for use.

Fixes: 197b88fecc50 ("mtd: rawnand: arasan: Add new Arasan NAND controller")
Cc: stable@vger.kernel.org
Signed-off-by: Maciej Andrzejewski ICEYE <maciej.andrzejewski@m-works.net>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mtd/nand/raw/arasan-nand-controller.c

index 50d1b8b8b0f7b61791314c1a62dcc849ebd36651..864c0524c9eac53e82401c4d139a46fb595f191d 100644 (file)
@@ -1510,8 +1510,15 @@ disable_controller_clk:
 
 static int anfc_remove(struct platform_device *pdev)
 {
+       int i;
        struct arasan_nfc *nfc = platform_get_drvdata(pdev);
 
+       for (i = 0; i < nfc->ncs; i++) {
+               if (nfc->cs_array[i]) {
+                       gpiod_put(nfc->cs_array[i]);
+               }
+       }
+
        anfc_chips_cleanup(nfc);
 
        clk_disable_unprepare(nfc->bus_clk);