]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
c++: Distinguish alignof and __alignof__ in cp_tree_equal [PR97273]
authorPatrick Palka <ppalka@redhat.com>
Thu, 8 Oct 2020 23:31:57 +0000 (19:31 -0400)
committerPatrick Palka <ppalka@redhat.com>
Thu, 8 Oct 2020 23:31:57 +0000 (19:31 -0400)
cp_tree_equal currently considers alignof the same as __alignof__, but
these operators are semantically different ever since r8-7957.  In the
testcase below, this causes the second static_assert to fail on targets
where alignof(double) != __alignof__(double) because the specialization
table (which uses cp_tree_equal as its equality predicate) conflates the
two dependent specializations integral_constant<__alignof__(T)> and
integral_constant<alignof(T)>.

This patch makes cp_tree_equal distinguish between these two operators
by inspecting the ALIGNOF_EXPR_STD_P flag.

gcc/cp/ChangeLog:

PR c++/88115
PR libstdc++/97273
* tree.c (cp_tree_equal) <case ALIGNOF_EXPR>: Return false if
ALIGNOF_EXPR_STD_P differ.

gcc/testsuite/ChangeLog:

PR c++/88115
PR libstdc++/97273
* g++.dg/template/alignof3.C: New test.

(cherry picked from commit 592fe221735bdaa375b1834dd49ce125d0b600d8)

gcc/cp/tree.c
gcc/testsuite/g++.dg/template/alignof3.C [new file with mode: 0644]

index 8840932dba255f74869a5034c2beaea17b47e80d..59fa0903015d2bed421a3cc0c889ddd0352c0c13 100644 (file)
@@ -3811,6 +3811,8 @@ cp_tree_equal (tree t1, tree t2)
            if (SIZEOF_EXPR_TYPE_P (t2))
              o2 = TREE_TYPE (o2);
          }
+       else if (ALIGNOF_EXPR_STD_P (t1) != ALIGNOF_EXPR_STD_P (t2))
+         return false;
 
        if (TREE_CODE (o1) != TREE_CODE (o2))
          return false;
diff --git a/gcc/testsuite/g++.dg/template/alignof3.C b/gcc/testsuite/g++.dg/template/alignof3.C
new file mode 100644 (file)
index 0000000..e573727
--- /dev/null
@@ -0,0 +1,13 @@
+// PR c++/88115
+// { dg-do compile { target c++11 } }
+
+template<int __v>
+struct integral_constant {
+  static constexpr int value = __v;
+};
+
+template <class T> using StdAlignOf = integral_constant<alignof(T)>;
+template <class T> using GCCAlignOf = integral_constant<__alignof__(T)>;
+
+static_assert(StdAlignOf<double>::value == alignof(double), "");
+static_assert(GCCAlignOf<double>::value == __alignof__(double), "");