]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: rzg2l-cru: rzg2l-core: Use local variable for struct device in rzg2l_cru_probe()
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Fri, 11 Apr 2025 17:05:34 +0000 (19:05 +0200)
committerHans Verkuil <hverkuil@xs4all.nl>
Wed, 23 Apr 2025 08:55:53 +0000 (10:55 +0200)
Use a local variable for the struct device pointers. This increases code
readability with shortened lines.

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Link: https://lore.kernel.org/r/20250411170624.472257-7-tommaso.merciai.xr@bp.renesas.com
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c

index 89be584a49885203c9e213e1cf1e4e37cb974f8f..70fed0ce45ea0afb6cd66f14a77bd305f4bf6388 100644 (file)
@@ -240,10 +240,11 @@ static int rzg2l_cru_media_init(struct rzg2l_cru_dev *cru)
 
 static int rzg2l_cru_probe(struct platform_device *pdev)
 {
+       struct device *dev = &pdev->dev;
        struct rzg2l_cru_dev *cru;
        int irq, ret;
 
-       cru = devm_kzalloc(&pdev->dev, sizeof(*cru), GFP_KERNEL);
+       cru = devm_kzalloc(dev, sizeof(*cru), GFP_KERNEL);
        if (!cru)
                return -ENOMEM;
 
@@ -251,32 +252,32 @@ static int rzg2l_cru_probe(struct platform_device *pdev)
        if (IS_ERR(cru->base))
                return PTR_ERR(cru->base);
 
-       cru->presetn = devm_reset_control_get_shared(&pdev->dev, "presetn");
+       cru->presetn = devm_reset_control_get_shared(dev, "presetn");
        if (IS_ERR(cru->presetn))
-               return dev_err_probe(&pdev->dev, PTR_ERR(cru->presetn),
+               return dev_err_probe(dev, PTR_ERR(cru->presetn),
                                     "Failed to get cpg presetn\n");
 
-       cru->aresetn = devm_reset_control_get_exclusive(&pdev->dev, "aresetn");
+       cru->aresetn = devm_reset_control_get_exclusive(dev, "aresetn");
        if (IS_ERR(cru->aresetn))
-               return dev_err_probe(&pdev->dev, PTR_ERR(cru->aresetn),
+               return dev_err_probe(dev, PTR_ERR(cru->aresetn),
                                     "Failed to get cpg aresetn\n");
 
-       cru->vclk = devm_clk_get(&pdev->dev, "video");
+       cru->vclk = devm_clk_get(dev, "video");
        if (IS_ERR(cru->vclk))
-               return dev_err_probe(&pdev->dev, PTR_ERR(cru->vclk),
+               return dev_err_probe(dev, PTR_ERR(cru->vclk),
                                     "Failed to get video clock\n");
 
-       cru->dev = &pdev->dev;
-       cru->info = of_device_get_match_data(&pdev->dev);
+       cru->dev = dev;
+       cru->info = of_device_get_match_data(dev);
 
        irq = platform_get_irq(pdev, 0);
        if (irq < 0)
                return irq;
 
-       ret = devm_request_irq(&pdev->dev, irq, rzg2l_cru_irq, 0,
+       ret = devm_request_irq(dev, irq, rzg2l_cru_irq, 0,
                               KBUILD_MODNAME, cru);
        if (ret)
-               return dev_err_probe(&pdev->dev, ret, "failed to request irq\n");
+               return dev_err_probe(dev, ret, "failed to request irq\n");
 
        platform_set_drvdata(pdev, cru);
 
@@ -285,8 +286,8 @@ static int rzg2l_cru_probe(struct platform_device *pdev)
                return ret;
 
        cru->num_buf = RZG2L_CRU_HW_BUFFER_DEFAULT;
-       pm_suspend_ignore_children(&pdev->dev, true);
-       pm_runtime_enable(&pdev->dev);
+       pm_suspend_ignore_children(dev, true);
+       pm_runtime_enable(dev);
 
        ret = rzg2l_cru_media_init(cru);
        if (ret)
@@ -296,7 +297,7 @@ static int rzg2l_cru_probe(struct platform_device *pdev)
 
 error_dma_unregister:
        rzg2l_cru_dma_unregister(cru);
-       pm_runtime_disable(&pdev->dev);
+       pm_runtime_disable(dev);
 
        return ret;
 }