]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915/backlight: Use drm helper to set edp backlight
authorSuraj Kandpal <suraj.kandpal@intel.com>
Fri, 20 Jun 2025 06:34:44 +0000 (12:04 +0530)
committerSuraj Kandpal <suraj.kandpal@intel.com>
Mon, 30 Jun 2025 15:11:50 +0000 (20:41 +0530)
Now that the drm helper sets the backlight using luminance
too we can use that. Remove the obselete function.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
Link: https://lore.kernel.org/r/20250620063445.3603086-13-suraj.kandpal@intel.com
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c

index d5cab87b326733fc388d5578b47ed53053572e5d..e1fd6773cc04be11b9ace7966e5412e790cc1758 100644 (file)
@@ -475,31 +475,6 @@ static u32 intel_dp_aux_vesa_get_backlight(struct intel_connector *connector, en
        return connector->panel.backlight.level;
 }
 
-static int
-intel_dp_aux_vesa_set_luminance(struct intel_connector *connector, u32 level)
-{
-       struct intel_dp *intel_dp = enc_to_intel_dp(connector->encoder);
-       u8 buf[3];
-       int ret;
-
-       level = level * 1000;
-       level &= 0xffffff;
-       buf[0] = (level & 0x0000ff);
-       buf[1] = (level & 0x00ff00) >> 8;
-       buf[2] = (level & 0xff0000) >> 16;
-
-       ret = drm_dp_dpcd_write(&intel_dp->aux, DP_EDP_PANEL_TARGET_LUMINANCE_VALUE,
-                               buf, sizeof(buf));
-       if (ret != sizeof(buf)) {
-               drm_err(intel_dp->aux.drm_dev,
-                       "%s: Failed to set VESA Aux Luminance: %d\n",
-                       intel_dp->aux.name, ret);
-               return -EINVAL;
-       } else {
-               return 0;
-       }
-}
-
 static void
 intel_dp_aux_vesa_set_backlight(const struct drm_connector_state *conn_state, u32 level)
 {
@@ -507,11 +482,6 @@ intel_dp_aux_vesa_set_backlight(const struct drm_connector_state *conn_state, u3
        struct intel_panel *panel = &connector->panel;
        struct intel_dp *intel_dp = enc_to_intel_dp(connector->encoder);
 
-       if (panel->backlight.edp.vesa.luminance_control_support) {
-               if (!intel_dp_aux_vesa_set_luminance(connector, level))
-                       return;
-       }
-
        if (!panel->backlight.edp.vesa.info.aux_set) {
                const u32 pwm_level = intel_backlight_level_to_pwm(connector, level);
 
@@ -537,7 +507,9 @@ intel_dp_aux_vesa_enable_backlight(const struct intel_crtc_state *crtc_state,
                if (ret == 1)
                        return;
 
-               if (!intel_dp_aux_vesa_set_luminance(connector, level))
+               if (!drm_edp_backlight_set_level(&intel_dp->aux,
+                                                &panel->backlight.edp.vesa.info,
+                                                level))
                        return;
        }