]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
pinctrl: realtek: Fix grammar in error messages
authorYu-Chun Lin <eleanor.lin@realtek.com>
Fri, 6 Mar 2026 07:52:35 +0000 (15:52 +0800)
committerLinus Walleij <linusw@kernel.org>
Tue, 10 Mar 2026 09:25:57 +0000 (10:25 +0100)
Correct the grammar in dev_err() messages. Change "Not support <feature>..."
to "<feature> unsupported..." to improve readability and comply with
standard English usage.

Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>
Signed-off-by: Linus Walleij <linusw@kernel.org>
drivers/pinctrl/realtek/pinctrl-rtd.c

index 382bdae54bf33e333d9497d3f1f63566cb8b63e0..5888a36babba40eb013619fe27c8dff32bd81a53 100644 (file)
@@ -293,14 +293,14 @@ static int rtd_pconf_parse_conf(struct rtd_pinctrl *data,
 
        config_desc = rtd_pinctrl_find_config(data, pinnr);
        if (!config_desc) {
-               dev_err(data->dev, "Not support pin config for pin: %s\n", name);
+               dev_err(data->dev, "Pin config unsupported for pin: %s\n", name);
                return -ENOTSUPP;
        }
        switch ((u32)param) {
        case PIN_CONFIG_INPUT_SCHMITT:
        case PIN_CONFIG_INPUT_SCHMITT_ENABLE:
                if (config_desc->smt_offset == NA) {
-                       dev_err(data->dev, "Not support input schmitt for pin: %s\n", name);
+                       dev_err(data->dev, "Input schmitt unsupported for pin: %s\n", name);
                        return -ENOTSUPP;
                }
                smt_off = config_desc->base_bit + config_desc->smt_offset;
@@ -313,7 +313,7 @@ static int rtd_pconf_parse_conf(struct rtd_pinctrl *data,
 
        case PIN_CONFIG_DRIVE_PUSH_PULL:
                if (config_desc->pud_en_offset == NA) {
-                       dev_err(data->dev, "Not support push pull for pin: %s\n", name);
+                       dev_err(data->dev, "Push pull unsupported for pin: %s\n", name);
                        return -ENOTSUPP;
                }
                pulen_off = config_desc->base_bit + config_desc->pud_en_offset;
@@ -325,7 +325,7 @@ static int rtd_pconf_parse_conf(struct rtd_pinctrl *data,
 
        case PIN_CONFIG_BIAS_DISABLE:
                if (config_desc->pud_en_offset == NA) {
-                       dev_err(data->dev, "Not support bias disable for pin: %s\n", name);
+                       dev_err(data->dev, "Bias disable unsupported for pin: %s\n", name);
                        return -ENOTSUPP;
                }
                pulen_off = config_desc->base_bit + config_desc->pud_en_offset;
@@ -337,7 +337,7 @@ static int rtd_pconf_parse_conf(struct rtd_pinctrl *data,
 
        case PIN_CONFIG_BIAS_PULL_UP:
                if (config_desc->pud_en_offset == NA) {
-                       dev_err(data->dev, "Not support bias pull up for pin:%s\n", name);
+                       dev_err(data->dev, "Bias pull up unsupported for pin:%s\n", name);
                        return -ENOTSUPP;
                }
                pulen_off = config_desc->base_bit + config_desc->pud_en_offset;
@@ -350,7 +350,7 @@ static int rtd_pconf_parse_conf(struct rtd_pinctrl *data,
 
        case PIN_CONFIG_BIAS_PULL_DOWN:
                if (config_desc->pud_en_offset == NA) {
-                       dev_err(data->dev, "Not support bias pull down for pin: %s\n", name);
+                       dev_err(data->dev, "Bias pull down unsupported for pin: %s\n", name);
                        return -ENOTSUPP;
                }
                pulen_off = config_desc->base_bit + config_desc->pud_en_offset;
@@ -384,7 +384,7 @@ static int rtd_pconf_parse_conf(struct rtd_pinctrl *data,
                                return -EINVAL;
                        break;
                case NA:
-                       dev_err(data->dev, "Not support drive strength for pin: %s\n", name);
+                       dev_err(data->dev, "Drive strength unsupported for pin: %s\n", name);
                        return -ENOTSUPP;
                default:
                        return -EINVAL;
@@ -394,7 +394,7 @@ static int rtd_pconf_parse_conf(struct rtd_pinctrl *data,
 
        case PIN_CONFIG_POWER_SOURCE:
                if (config_desc->power_offset == NA) {
-                       dev_err(data->dev, "Not support power source for pin: %s\n", name);
+                       dev_err(data->dev, "Power source unsupported for pin: %s\n", name);
                        return -ENOTSUPP;
                }
                reg_off = config_desc->reg_offset;
@@ -411,7 +411,7 @@ static int rtd_pconf_parse_conf(struct rtd_pinctrl *data,
        case RTD_DRIVE_STRENGH_P:
                sconfig_desc = rtd_pinctrl_find_sconfig(data, pinnr);
                if (!sconfig_desc) {
-                       dev_err(data->dev, "Not support P driving for pin: %s\n", name);
+                       dev_err(data->dev, "P driving unsupported for pin: %s\n", name);
                        return -ENOTSUPP;
                }
                set_val = arg;
@@ -428,7 +428,7 @@ static int rtd_pconf_parse_conf(struct rtd_pinctrl *data,
        case RTD_DRIVE_STRENGH_N:
                sconfig_desc = rtd_pinctrl_find_sconfig(data, pinnr);
                if (!sconfig_desc) {
-                       dev_err(data->dev, "Not support N driving for pin: %s\n", name);
+                       dev_err(data->dev, "N driving unsupported for pin: %s\n", name);
                        return -ENOTSUPP;
                }
                set_val = arg;
@@ -445,7 +445,7 @@ static int rtd_pconf_parse_conf(struct rtd_pinctrl *data,
        case RTD_DUTY_CYCLE:
                sconfig_desc = rtd_pinctrl_find_sconfig(data, pinnr);
                if (!sconfig_desc || sconfig_desc->dcycle_offset == NA) {
-                       dev_err(data->dev, "Not support duty cycle for pin: %s\n", name);
+                       dev_err(data->dev, "Duty cycle unsupported for pin: %s\n", name);
                        return -ENOTSUPP;
                }
                set_val = arg;