]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
skip dupe order by test on mssql
authorMike Bayer <mike_mp@zzzcomputing.com>
Sat, 29 May 2021 15:05:25 +0000 (11:05 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Sat, 29 May 2021 15:05:25 +0000 (11:05 -0400)
SQL Server wants to complain if ORDER BY specifies the same
expression more than once, so just skip this test added in
aaba0650d7410f579b2c14f8f1b0680a1d1852c4 as this only needs
to test ORM functionality.

Change-Id: I857746771ed9c661043d7a8661efe9f47449c466

test/orm/test_dynamic.py
test/requirements.py

index 68547b1539d3abadc6a3794b18ddf03b41edc132..b4ab4047d5f50513b610570548ee80a5c8c8c386 100644 (file)
@@ -343,6 +343,7 @@ class DynamicTest(_DynamicFixture, _fixtures.FixtureTest, AssertsCompiledSQL):
             ],
         )
 
+    @testing.requires.dupe_order_by_ok
     def test_order_by_composition_uses_immutable_tuple(self):
         addresses = self.tables.addresses
         User, Address = self._user_address_fixture(
index 6628d9ef3895432d32a8f82db497e1018d72c3e8..86ae3d4b5b4e416a82b8f744f3abc136a9c1d613 100644 (file)
@@ -705,6 +705,15 @@ class DefaultRequirements(SuiteRequirements):
             "no support for EXCEPT",
         )
 
+    @property
+    def dupe_order_by_ok(self):
+        """target db wont choke if ORDER BY specifies the same expression
+        more than once
+
+        """
+
+        return skip_if("mssql")
+
     @property
     def order_by_col_from_union(self):
         """target database supports ordering by a column from a SELECT