]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
syntax-check: Prohibit 'vir' prefix for enum implementations in virsh
authorPeter Krempa <pkrempa@redhat.com>
Tue, 13 Jul 2021 09:52:20 +0000 (11:52 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 23 Jul 2021 07:59:12 +0000 (09:59 +0200)
Avoid potential conflict of enum helpers declared in virsh.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
build-aux/syntax-check.mk

index 256f9f695a2e0a757f0a4d8b73b190bb877a81e9..cedb360bfdec947ac14531fb6e529816799f1722 100644 (file)
@@ -1717,6 +1717,13 @@ sc_group-qemu-caps:
        $(AM_V_GEN)$(RUNUTF8) $(PYTHON) $(top_srcdir)/scripts/group-qemu-caps.py \
                --check --prefix $(top_srcdir)/
 
+sc_prohibit_enum_impl_with_vir_prefix_in_virsh:
+       @prohibit='VIR_ENUM_(IMPL|DECL)\(vir[^s]'                       \
+       in_vc_files='tools/virsh.*\.[ch]$$'                                     \
+       halt='avoid "vir" prefix for enums in virsh'                            \
+         $(_sc_search_regexp)
+
+
 # List all syntax-check exemptions:
 exclude_file_name_regexp--sc_avoid_strcase = ^tools/vsh\.h$$