detect: remove unneeded NULL check

As spotted by cppcheck

fd is set only once, and DetectFlowSetup bails early if it is NULL

Fixes: c272a646c5ae ("detect: SigMatchAppendSMToList can fail")

diff --git a/src/detect-flow.c b/src/detect-flow.c
index f2de380ef554ac37951cee981a045c93941a7e36..cf267a6e0ebdc75f7a159726267b532956541396 100644 (file)
--- a/src/detect-flow.c
+++ b/src/detect-flow.c
@@ -422,7 +422,7 @@ int DetectFlowSetup (DetectEngineCtx *de_ctx, Signature *s, const char *flowstr)
                     de_ctx, s, DETECT_FLOW, (SigMatchCtx *)fd, DETECT_SM_LIST_MATCH) == NULL) {
             goto error;
         }
-    } else if (fd != NULL) {
+    } else {
         DetectFlowFree(de_ctx, fd);
     }