spi: tegra210-quad: add rate limiting and simplify timeout error message

[ Upstream commit 21f4314e66ed8d40b2ee24185d1a06a07a512eb1 ]

On malfunctioning hardware, timeout error messages can appear thousands
of times, creating unnecessary system pressure and log bloat. This patch
makes two improvements:

1. Replace dev_err() with dev_err_ratelimited() to prevent log flooding
   when hardware errors persist
2. Remove the redundant timeout value parameter from the error message,
   as 'ret' is always zero in this error path

These changes reduce logging overhead while maintaining necessary error
reporting for debugging purposes.

Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20250401-tegra-v2-2-126c293ec047@debian.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/spi/spi-tegra210-quad.c b/drivers/spi/spi-tegra210-quad.c
index 97f3a4d3c31a9a3cedc313c0143cd9e0d81ecb99..442d42130ec8717d532913e1012fa95337002d7f 100644 (file)
--- a/drivers/spi/spi-tegra210-quad.c
+++ b/drivers/spi/spi-tegra210-quad.c
@@ -1111,8 +1111,8 @@ static int tegra_qspi_combined_seq_xfer(struct tegra_qspi *tqspi,
                                        QSPI_DMA_TIMEOUT);
 
                        if (WARN_ON_ONCE(ret == 0)) {
-                               dev_err(tqspi->dev, "QSPI Transfer failed with timeout: %d\n",
-                                       ret);
+                               dev_err_ratelimited(tqspi->dev,
+                                                   "QSPI Transfer failed with timeout\n");
                                if (tqspi->is_curr_dma_xfer &&
                                    (tqspi->cur_direction & DATA_DIR_TX))
                                        dmaengine_terminate_all