unlinkd: Compiler warning cleanups

Check the return value for open(/dev/null). Nothing we can do about it
since the daemon has already disconnected from cache.log but note that.

 Detected by Coverity Scan. Issue 740328

diff --git a/src/unlinkd_daemon.cc b/src/unlinkd_daemon.cc
index e9dbf53e5e0ed9765baf874ecf57131327cf4407..126472b2f3987f6a14b685ca70913bd598b787c3 100644 (file)
--- a/src/unlinkd_daemon.cc
+++ b/src/unlinkd_daemon.cc
@@ -79,9 +79,11 @@ main(int argc, char *argv[])
     setbuf(stdin, NULL);
     setbuf(stdout, NULL);
     close(2);
-    open(_PATH_DEVNULL, O_RDWR);
+    if (open(_PATH_DEVNULL, O_RDWR) < 0) {
+        ; // the irony of having to close(2) earlier is that we cannot report this failure.
+    }
 
-    while (fgets(buf, UNLINK_BUF_LEN, stdin)) {
+    while (fgets(buf, sizeof(buf), stdin)) {
         if ((t = strchr(buf, '\n')))
             *t = '\0';
         x = unlink(buf);