]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
clk: nxp: lpc32xx: convert from divider_round_rate() to divider_determine_rate()
authorBrian Masney <bmasney@redhat.com>
Thu, 8 Jan 2026 21:16:31 +0000 (16:16 -0500)
committerBrian Masney <bmasney@redhat.com>
Thu, 22 Jan 2026 15:48:25 +0000 (10:48 -0500)
The divider_round_rate() function is now deprecated, so let's migrate
to divider_determine_rate() instead so that this deprecated API can be
removed.

Note that when the main function itself was migrated to use
determine_rate, this was mistakenly converted to:

    req->rate = divider_round_rate(...)

This is invalid in the case when an error occurs since it can set the
rate to a negative value.

Fixes: 0879768df240 ("clk: nxp: lpc32xx: convert from round_rate() to determine_rate()")
Tested-by: Vladimir Zapolskiy <vz@mleia.com>
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Brian Masney <bmasney@redhat.com>
drivers/clk/nxp/clk-lpc32xx.c

index 23f980cf6a2b59ee1c93a2519fe5188d251fa12f..ae2fa5341a2e4fbe5f2d3ef9a6cf9e9d75180d59 100644 (file)
@@ -975,10 +975,8 @@ static int clk_divider_determine_rate(struct clk_hw *hw,
                return 0;
        }
 
-       req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate,
-                                      divider->table, divider->width, divider->flags);
-
-       return 0;
+       return divider_determine_rate(hw, req, divider->table, divider->width,
+                                     divider->flags);
 }
 
 static int clk_divider_set_rate(struct clk_hw *hw, unsigned long rate,