]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
simplify dns_name_fromtext() interface
authorEvan Hunt <each@isc.org>
Sat, 22 Feb 2025 08:11:38 +0000 (00:11 -0800)
committerEvan Hunt <each@isc.org>
Tue, 25 Feb 2025 20:53:25 +0000 (12:53 -0800)
previously, dns_name_fromtext() took both a target name and an
optional target buffer parameter, which could override the name's
dedicated buffer. this interface is unnecessarily complex.

we now have two functions, dns_name_fromtext() to convert text
into a dns_name that has a dedicated buffer, and dns_name_wirefromtext()
to convert text into uncompressed DNS wire format and append it to a
target buffer.

in cases where it really is necessary to have both, we can use
dns_name_fromtext() to load the dns_name, then dns_name_towire()
to append the wire format to the target buffer.

89 files changed:
bin/check/check-tool.c
bin/delv/delv.c
bin/dig/dighost.c
bin/dnssec/dnssec-cds.c
bin/dnssec/dnssec-dsfromkey.c
bin/dnssec/dnssec-importkey.c
bin/dnssec/dnssec-keyfromlabel.c
bin/dnssec/dnssec-keygen.c
bin/dnssec/dnssec-ksr.c
bin/dnssec/dnssec-signzone.c
bin/dnssec/dnssec-verify.c
bin/named/config.c
bin/named/server.c
bin/named/tkeyconf.c
bin/named/transportconf.c
bin/named/tsigconf.c
bin/named/zoneconf.c
bin/nsupdate/nsupdate.c
bin/tests/system/pipelined/pipequeries.c
bin/tools/mdig.c
bin/tools/nsec3hash.c
fuzz/dns_name_fromtext_target.c
lib/dns/byaddr.c
lib/dns/dlz.c
lib/dns/dst_api.c
lib/dns/gssapictx.c
lib/dns/include/dns/name.h
lib/dns/master.c
lib/dns/name.c
lib/dns/nsec3.c
lib/dns/peer.c
lib/dns/rdata/any_255/tsig_250.c
lib/dns/rdata/ch_3/a_1.c
lib/dns/rdata/generic/afsdb_18.c
lib/dns/rdata/generic/amtrelay_260.c
lib/dns/rdata/generic/cname_5.c
lib/dns/rdata/generic/dname_39.c
lib/dns/rdata/generic/hip_55.c
lib/dns/rdata/generic/ipseckey_45.c
lib/dns/rdata/generic/lp_107.c
lib/dns/rdata/generic/mb_7.c
lib/dns/rdata/generic/md_3.c
lib/dns/rdata/generic/mf_4.c
lib/dns/rdata/generic/mg_8.c
lib/dns/rdata/generic/minfo_14.c
lib/dns/rdata/generic/mr_9.c
lib/dns/rdata/generic/mx_15.c
lib/dns/rdata/generic/naptr_35.c
lib/dns/rdata/generic/ns_2.c
lib/dns/rdata/generic/nsec_47.c
lib/dns/rdata/generic/nxt_30.c
lib/dns/rdata/generic/ptr_12.c
lib/dns/rdata/generic/rp_17.c
lib/dns/rdata/generic/rrsig_46.c
lib/dns/rdata/generic/rt_21.c
lib/dns/rdata/generic/sig_24.c
lib/dns/rdata/generic/soa_6.c
lib/dns/rdata/generic/talink_58.c
lib/dns/rdata/generic/tkey_249.c
lib/dns/rdata/in_1/a6_38.c
lib/dns/rdata/in_1/kx_36.c
lib/dns/rdata/in_1/nsap-ptr_23.c
lib/dns/rdata/in_1/px_26.c
lib/dns/rdata/in_1/srv_33.c
lib/dns/rdata/in_1/svcb_64.c
lib/dns/rpz.c
lib/dns/sdlz.c
lib/dns/skr.c
lib/dns/ssu.c
lib/dns/tkey.c
lib/dns/tsig.c
lib/dns/view.c
lib/isccfg/aclconf.c
lib/isccfg/check.c
tests/bench/compress.c
tests/bench/load-names.c
tests/bench/qp-dump.c
tests/bench/qplookups.c
tests/dns/dbiterator_test.c
tests/dns/dispatch_test.c
tests/dns/dnstap_test.c
tests/dns/dst_test.c
tests/dns/keytable_test.c
tests/dns/master_test.c
tests/dns/name_test.c
tests/dns/qpzone_test.c
tests/dns/rsa_test.c
tests/dns/skr_test.c
tests/libtest/dns.c

index 794160e04b5eb986107cdc4f02b8ecb19257d72c..bd2733b69a347a9be2bfd242fd718130a24cfd3d 100644 (file)
@@ -655,7 +655,7 @@ load_zone(isc_mem_t *mctx, const char *zonename, const char *filename,
        isc_buffer_constinit(&buffer, zonename, strlen(zonename));
        isc_buffer_add(&buffer, strlen(zonename));
        origin = dns_fixedname_initname(&fixorigin);
-       CHECK(dns_name_fromtext(origin, &buffer, dns_rootname, 0, NULL));
+       CHECK(dns_name_fromtext(origin, &buffer, dns_rootname, 0));
        dns_zone_setorigin(zone, origin);
        dns_zone_setdbtype(zone, 1, (const char *const *)dbtype);
        if (strcmp(filename, "-") == 0) {
index 2088088d46469c966c364f03072d1a19b2e4c407..1d63d143fd533e92426794f4e5c569291cbe29a2 100644 (file)
@@ -597,7 +597,7 @@ convert_name(dns_fixedname_t *fn, dns_name_t **name, const char *text) {
        isc_buffer_add(&b, len);
        n = dns_fixedname_initname(fn);
 
-       result = dns_name_fromtext(n, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(n, &b, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                delv_log(ISC_LOG_ERROR, "failed to convert name %s: %s", text,
                         isc_result_totext(result));
index 2f43fb6998f445da3dd5e8aac87ad7dd63e86783..69a310d2f3c2d04f3a58e59a972bd27f9ae8a164 100644 (file)
@@ -882,7 +882,7 @@ setup_text_key(void) {
                goto failure;
        }
 
-       result = dns_name_fromtext(keyname, namebuf, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(keyname, namebuf, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                goto failure;
        }
@@ -2252,8 +2252,7 @@ setup_lookup(dig_lookup_t *lookup) {
                len = (unsigned int)strlen(origin);
                isc_buffer_init(&b, origin, len);
                isc_buffer_add(&b, len);
-               result = dns_name_fromtext(lookup->oname, &b, dns_rootname, 0,
-                                          NULL);
+               result = dns_name_fromtext(lookup->oname, &b, dns_rootname, 0);
                if (result != ISC_R_SUCCESS) {
                        dns_message_puttempname(lookup->sendmsg, &lookup->name);
                        dns_message_puttempname(lookup->sendmsg,
@@ -2271,7 +2270,7 @@ setup_lookup(dig_lookup_t *lookup) {
                        len = (unsigned int)strlen(textname);
                        isc_buffer_init(&b, textname, len);
                        isc_buffer_add(&b, len);
-                       result = dns_name_fromtext(name, &b, NULL, 0, NULL);
+                       result = dns_name_fromtext(name, &b, NULL, 0);
                        if (result == ISC_R_SUCCESS) {
                                if (!dns_name_isabsolute(name)) {
                                        result = dns_name_concatenate(
@@ -2304,7 +2303,7 @@ setup_lookup(dig_lookup_t *lookup) {
                        isc_buffer_init(&b, textname, len);
                        isc_buffer_add(&b, len);
                        result = dns_name_fromtext(lookup->name, &b,
-                                                  dns_rootname, 0, NULL);
+                                                  dns_rootname, 0);
                        if (result != ISC_R_SUCCESS) {
                                dns_message_puttempname(lookup->sendmsg,
                                                        &lookup->name);
index fbf319c356b26283fc531e321451b3fe3d03cf6d..13368126ef1dbfb55f9902a1efab7dd60568028e 100644 (file)
@@ -178,7 +178,7 @@ initname(char *setname) {
 
        isc_buffer_init(&buf, setname, strlen(setname));
        isc_buffer_add(&buf, strlen(setname));
-       result = dns_name_fromtext(name, &buf, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name, &buf, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                fatal("could not initialize name %s", setname);
        }
index 00c1bab86e4be3896a7053aeb747d04bea9ef3b5..9647638eac7451625e670efa65197de4554b90ab 100644 (file)
@@ -67,7 +67,7 @@ initname(char *setname) {
 
        isc_buffer_init(&buf, setname, strlen(setname));
        isc_buffer_add(&buf, strlen(setname));
-       result = dns_name_fromtext(name, &buf, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name, &buf, dns_rootname, 0);
        return result;
 }
 
index 95ac0256bae97d2a005b5ad7cf382eb2f233fccc..3d5ca6724e340568dc87976ac77130d3bf565711 100644 (file)
@@ -69,7 +69,7 @@ initname(char *setname) {
 
        isc_buffer_init(&buf, setname, strlen(setname));
        isc_buffer_add(&buf, strlen(setname));
-       result = dns_name_fromtext(name, &buf, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name, &buf, dns_rootname, 0);
        return result;
 }
 
index 3b8899960ba10bb08f307513a5bfae340205cdfd..dadf6e0c9bb88f08d5b3a29c6226300d240f6eef 100644 (file)
@@ -367,7 +367,7 @@ main(int argc, char **argv) {
                isc_buffer_init(&buf, argv[isc_commandline_index],
                                strlen(argv[isc_commandline_index]));
                isc_buffer_add(&buf, strlen(argv[isc_commandline_index]));
-               ret = dns_name_fromtext(name, &buf, dns_rootname, 0, NULL);
+               ret = dns_name_fromtext(name, &buf, dns_rootname, 0);
                if (ret != ISC_R_SUCCESS) {
                        fatal("invalid key name %s: %s",
                              argv[isc_commandline_index],
index 36ed720ec8f800b067bee1f5731c34ffd825adb5..e04f73bd11eb0aea501739eb881ebbf620015da1 100644 (file)
@@ -277,7 +277,7 @@ keygen(keygen_ctx_t *ctx, isc_mem_t *mctx, int argc, char **argv) {
                isc_buffer_init(&buf, argv[isc_commandline_index],
                                strlen(argv[isc_commandline_index]));
                isc_buffer_add(&buf, strlen(argv[isc_commandline_index]));
-               ret = dns_name_fromtext(name, &buf, dns_rootname, 0, NULL);
+               ret = dns_name_fromtext(name, &buf, dns_rootname, 0);
                if (ret != ISC_R_SUCCESS) {
                        fatal("invalid key name %s: %s",
                              argv[isc_commandline_index],
index 95b1e4b7e5487f0eabe799583cd43874b8a4fa52..3260e3ff645b99593235b9d26564dde1bdade97c 100644 (file)
@@ -1008,7 +1008,7 @@ parse_dnskey(isc_lex_t *lex, char *owner, isc_buffer_t *buf, dns_ttl_t *ttl) {
        dname = dns_fixedname_initname(&dfname);
        isc_buffer_init(&b, owner, strlen(owner));
        isc_buffer_add(&b, strlen(owner));
-       ret = dns_name_fromtext(dname, &b, dns_rootname, 0, NULL);
+       ret = dns_name_fromtext(dname, &b, dns_rootname, 0);
        if (ret != ISC_R_SUCCESS) {
                return ret;
        }
@@ -1455,7 +1455,7 @@ main(int argc, char *argv[]) {
        name = dns_fixedname_initname(&fname);
        isc_buffer_init(&buf, argv[1], strlen(argv[1]));
        isc_buffer_add(&buf, strlen(argv[1]));
-       ret = dns_name_fromtext(name, &buf, dns_rootname, 0, NULL);
+       ret = dns_name_fromtext(name, &buf, dns_rootname, 0);
        if (ret != ISC_R_SUCCESS) {
                fatal("invalid zone name %s: %s", argv[1],
                      isc_result_totext(ret));
index 7ef9236dff9230bc3f21af109772e3a01b6110b4..9101098470bbe64ca6a4c5aa481c71dec8f0d348 100644 (file)
@@ -2579,7 +2579,7 @@ loadzone(char *file, char *origin, dns_rdataclass_t rdclass, dns_db_t **db) {
        isc_buffer_add(&b, len);
 
        name = dns_fixedname_initname(&fname);
-       result = dns_name_fromtext(name, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name, &b, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                fatal("failed converting name '%s' to dns format: %s", origin,
                      isc_result_totext(result));
index 14a19277b0e9e329434fe332283bfe54a24832fe..1b00812c64c153bd24fc0b2684a22760cd03d9c1 100644 (file)
@@ -105,7 +105,7 @@ loadzone(char *file, char *origin, dns_rdataclass_t rdclass, dns_db_t **db) {
        isc_buffer_add(&b, len);
 
        name = dns_fixedname_initname(&fname);
-       result = dns_name_fromtext(name, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name, &b, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                fatal("failed converting name '%s' to dns format: %s", origin,
                      isc_result_totext(result));
index 5da15a526c2819ca1ca3cb55f43f80b3dd5f94d2..3ac41a80b2ad1936a0340f5e00f0936702d88923 100644 (file)
@@ -558,7 +558,7 @@ named_config_getname(isc_mem_t *mctx, const cfg_obj_t *obj,
        isc_buffer_add(&b, strlen(objstr));
        dns_fixedname_init(&fname);
        result = dns_name_fromtext(dns_fixedname_name(&fname), &b, dns_rootname,
-                                  0, NULL);
+                                  0);
        if (result != ISC_R_SUCCESS) {
                isc_mem_put(mctx, *namep, sizeof(**namep));
                *namep = NULL;
index 9f6d021bbfcd6d771a883c5c961d5de1747c0a36..236eadf61214939970f5fa5b278b3ae28d7cc2f6 100644 (file)
@@ -664,7 +664,7 @@ configure_view_nametable(const cfg_obj_t *vconfig, const cfg_obj_t *config,
                str = cfg_obj_asstring(nameobj);
                isc_buffer_constinit(&b, str, strlen(str));
                isc_buffer_add(&b, strlen(str));
-               CHECK(dns_name_fromtext(name, &b, dns_rootname, 0, NULL));
+               CHECK(dns_name_fromtext(name, &b, dns_rootname, 0));
                result = dns_nametree_add(*ntp, name, true);
                if (result != ISC_R_SUCCESS) {
                        cfg_obj_log(nameobj, ISC_LOG_ERROR,
@@ -724,7 +724,7 @@ ta_fromconfig(const cfg_obj_t *key, bool *initialp, const char **namestrp,
        name = dns_fixedname_initname(&fname);
        isc_buffer_constinit(&namebuf, namestr, strlen(namestr));
        isc_buffer_add(&namebuf, strlen(namestr));
-       CHECK(dns_name_fromtext(name, &namebuf, dns_rootname, 0, NULL));
+       CHECK(dns_name_fromtext(name, &namebuf, dns_rootname, 0));
 
        if (*initialp) {
                atstr = cfg_obj_asstring(cfg_tuple_get(key, "anchortype"));
@@ -913,7 +913,7 @@ process_key(const cfg_obj_t *key, dns_keytable_t *secroots,
                isc_buffer_constinit(&b, namestr, strlen(namestr));
                isc_buffer_add(&b, strlen(namestr));
                keyname = dns_fixedname_initname(&fkeyname);
-               result = dns_name_fromtext(keyname, &b, dns_rootname, 0, NULL);
+               result = dns_name_fromtext(keyname, &b, dns_rootname, 0);
                if (result != ISC_R_SUCCESS) {
                        return result;
                }
@@ -1306,7 +1306,7 @@ configure_order(dns_order_t *order, const cfg_obj_t *ent) {
        isc_buffer_add(&b, strlen(str));
        dns_fixedname_init(&fixed);
        result = dns_name_fromtext(dns_fixedname_name(&fixed), &b, dns_rootname,
-                                  0, NULL);
+                                  0);
        if (result != ISC_R_SUCCESS) {
                return result;
        }
@@ -1591,7 +1591,7 @@ disable_algorithms(const cfg_obj_t *disabled, dns_resolver_t *resolver) {
        str = cfg_obj_asstring(cfg_tuple_get(disabled, "name"));
        isc_buffer_constinit(&b, str, strlen(str));
        isc_buffer_add(&b, strlen(str));
-       CHECK(dns_name_fromtext(name, &b, dns_rootname, 0, NULL));
+       CHECK(dns_name_fromtext(name, &b, dns_rootname, 0));
 
        algorithms = cfg_tuple_get(disabled, "algorithms");
        for (element = cfg_list_first(algorithms); element != NULL;
@@ -1634,7 +1634,7 @@ disable_ds_digests(const cfg_obj_t *disabled, dns_resolver_t *resolver) {
        str = cfg_obj_asstring(cfg_tuple_get(disabled, "name"));
        isc_buffer_constinit(&b, str, strlen(str));
        isc_buffer_add(&b, strlen(str));
-       CHECK(dns_name_fromtext(name, &b, dns_rootname, 0, NULL));
+       CHECK(dns_name_fromtext(name, &b, dns_rootname, 0));
 
        digests = cfg_tuple_get(disabled, "digests");
        for (element = cfg_list_first(digests); element != NULL;
@@ -1678,7 +1678,7 @@ on_disable_list(const cfg_obj_t *disablelist, dns_name_t *zonename) {
                str = cfg_obj_asstring(value);
                isc_buffer_constinit(&b, str, strlen(str));
                isc_buffer_add(&b, strlen(str));
-               result = dns_name_fromtext(name, &b, dns_rootname, 0, NULL);
+               result = dns_name_fromtext(name, &b, dns_rootname, 0);
                RUNTIME_CHECK(result == ISC_R_SUCCESS);
                if (dns_name_equal(name, zonename)) {
                        return true;
@@ -1861,7 +1861,7 @@ dns64_reverse(dns_view_t *view, isc_mem_t *mctx, isc_netaddr_t *na,
        name = dns_fixedname_initname(&fixed);
        isc_buffer_constinit(&b, reverse, strlen(reverse));
        isc_buffer_add(&b, strlen(reverse));
-       CHECK(dns_name_fromtext(name, &b, dns_rootname, 0, NULL));
+       CHECK(dns_name_fromtext(name, &b, dns_rootname, 0));
        dns_zone_create(&zone, mctx, 0);
        dns_zone_setorigin(zone, name);
        dns_zone_setview(zone, view);
@@ -5876,8 +5876,8 @@ configure_alternates(const cfg_obj_t *config, dns_view_t *view,
                        isc_buffer_constinit(&buffer, str, strlen(str));
                        isc_buffer_add(&buffer, strlen(str));
                        name = dns_fixedname_initname(&fixed);
-                       CHECK(dns_name_fromtext(name, &buffer, dns_rootname, 0,
-                                               NULL));
+                       CHECK(dns_name_fromtext(name, &buffer, dns_rootname,
+                                               0));
 
                        portobj = cfg_tuple_get(alternate, "port");
                        if (cfg_obj_isuint32(portobj)) {
@@ -6232,7 +6232,7 @@ configure_zone(const cfg_obj_t *config, const cfg_obj_t *zconfig,
        isc_buffer_add(&buffer, strlen(zname));
        dns_fixedname_init(&fixorigin);
        CHECK(dns_name_fromtext(dns_fixedname_name(&fixorigin), &buffer,
-                               dns_rootname, 0, NULL));
+                               dns_rootname, 0));
        origin = dns_fixedname_name(&fixorigin);
 
        CHECK(named_config_getclass(cfg_tuple_get(zconfig, "class"),
@@ -7243,7 +7243,7 @@ configure_session_key(const cfg_obj_t **maps, named_server_t *server,
        isc_buffer_constinit(&buffer, keynamestr, strlen(keynamestr));
        isc_buffer_add(&buffer, strlen(keynamestr));
        keyname = dns_fixedname_initname(&fname);
-       result = dns_name_fromtext(keyname, &buffer, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(keyname, &buffer, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                return result;
        }
@@ -7801,8 +7801,7 @@ get_newzone_config(dns_view_t *view, const char *zonename,
        isc_buffer_constinit(&b, zonename, strlen(zonename));
        isc_buffer_add(&b, strlen(zonename));
        name = dns_fixedname_initname(&fname);
-       CHECK(dns_name_fromtext(name, &b, dns_rootname, DNS_NAME_DOWNCASE,
-                               NULL));
+       CHECK(dns_name_fromtext(name, &b, dns_rootname, DNS_NAME_DOWNCASE));
        dns_name_format(name, zname, sizeof(zname));
 
        key.mv_data = zname;
@@ -11833,7 +11832,7 @@ named_server_flushnode(named_server_t *server, isc_lex_t *lex, bool tree) {
        isc_buffer_constinit(&b, target, strlen(target));
        isc_buffer_add(&b, strlen(target));
        name = dns_fixedname_initname(&fixed);
-       result = dns_name_fromtext(name, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name, &b, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                return result;
        }
@@ -12943,7 +12942,7 @@ load_nzf(dns_view_t *view, ns_cfgctx_t *nzcfg) {
                isc_buffer_add(&b, strlen(origin));
                name = dns_fixedname_initname(&fname);
                CHECK(dns_name_fromtext(name, &b, dns_rootname,
-                                       DNS_NAME_DOWNCASE, NULL));
+                                       DNS_NAME_DOWNCASE));
                dns_name_format(name, zname, sizeof(zname));
 
                key.mv_data = zname;
@@ -13652,7 +13651,7 @@ named_server_changezone(named_server_t *server, char *command,
        isc_buffer_add(&buf, strlen(zonename));
 
        dnsname = dns_fixedname_initname(&fname);
-       CHECK(dns_name_fromtext(dnsname, &buf, dns_rootname, 0, NULL));
+       CHECK(dns_name_fromtext(dnsname, &buf, dns_rootname, 0));
 
        if (redirect) {
                if (!dns_name_equal(dnsname, dns_rootname)) {
@@ -15218,7 +15217,7 @@ named_server_nta(named_server_t *server, isc_lex_t *lex, bool readonly,
                isc_buffer_t b;
                isc_buffer_init(&b, namebuf, strlen(namebuf));
                isc_buffer_add(&b, strlen(namebuf));
-               CHECK(dns_name_fromtext(fname, &b, dns_rootname, 0, NULL));
+               CHECK(dns_name_fromtext(fname, &b, dns_rootname, 0));
                ntaname = fname;
        }
 
index 28beca3085609888a3420b82e1caac2885eaec2d..569a7873e97555fed5c0800342ca7dc7bff91faf 100644 (file)
@@ -62,7 +62,7 @@ named_tkeyctx_fromconfig(const cfg_obj_t *options, isc_mem_t *mctx,
                isc_buffer_constinit(&b, s, strlen(s));
                isc_buffer_add(&b, strlen(s));
                name = dns_fixedname_initname(&fname);
-               RETERR(dns_name_fromtext(name, &b, dns_rootname, 0, NULL));
+               RETERR(dns_name_fromtext(name, &b, dns_rootname, 0));
                tctx->domain = isc_mem_get(mctx, sizeof(dns_name_t));
                dns_name_init(tctx->domain);
                dns_name_dup(name, mctx, tctx->domain);
@@ -76,7 +76,7 @@ named_tkeyctx_fromconfig(const cfg_obj_t *options, isc_mem_t *mctx,
                isc_buffer_constinit(&b, s, strlen(s));
                isc_buffer_add(&b, strlen(s));
                name = dns_fixedname_initname(&fname);
-               RETERR(dns_name_fromtext(name, &b, dns_rootname, 0, NULL));
+               RETERR(dns_name_fromtext(name, &b, dns_rootname, 0));
                RETERR(dst_gssapi_acquirecred(name, false, &tctx->gsscred));
        }
 
index cfef81068aecdaae3c386753fdfd08b50c1813ac..5b904761eccccd0608425ce7ae39b9dbe255e773 100644 (file)
@@ -34,7 +34,7 @@
        isc_buffer_constinit(&namesrc, id, strlen(id));           \
        isc_buffer_add(&namesrc, strlen(id));                     \
        result = (dns_name_fromtext(name, &namesrc, dns_rootname, \
-                                   DNS_NAME_DOWNCASE, NULL));    \
+                                   DNS_NAME_DOWNCASE));          \
        if (result != ISC_R_SUCCESS) {                            \
                goto failure;                                     \
        }
index a51cdb87d346b04a6b7b5171d5576051379de48f..aa8be9dbaeb97e6c1098c648fd96ac66e5a936fc 100644 (file)
@@ -71,7 +71,7 @@ add_initial_keys(const cfg_obj_t *list, dns_tsigkeyring_t *ring,
                isc_buffer_constinit(&keynamesrc, keyid, strlen(keyid));
                isc_buffer_add(&keynamesrc, strlen(keyid));
                ret = dns_name_fromtext(keyname, &keynamesrc, dns_rootname,
-                                       DNS_NAME_DOWNCASE, NULL);
+                                       DNS_NAME_DOWNCASE);
                if (ret != ISC_R_SUCCESS) {
                        goto failure;
                }
index 1b1e8a818ada2ec42bd5a28056fdc6d985d93d7b..9b2dd18a760aee97f63d66ed518d0cad24a4d6cd 100644 (file)
@@ -253,7 +253,7 @@ configure_zone_ssutable(const cfg_obj_t *zconfig, dns_zone_t *zone,
                isc_buffer_constinit(&b, str, strlen(str));
                isc_buffer_add(&b, strlen(str));
                result = dns_name_fromtext(dns_fixedname_name(&fident), &b,
-                                          dns_rootname, 0, NULL);
+                                          dns_rootname, 0);
                if (result != ISC_R_SUCCESS) {
                        cfg_obj_log(identity, ISC_LOG_ERROR,
                                    "'%s' is not a valid name", str);
@@ -283,7 +283,7 @@ configure_zone_ssutable(const cfg_obj_t *zconfig, dns_zone_t *zone,
                        isc_buffer_constinit(&b, str, strlen(str));
                        isc_buffer_add(&b, strlen(str));
                        result = dns_name_fromtext(dns_fixedname_name(&fname),
-                                                  &b, dns_rootname, 0, NULL);
+                                                  &b, dns_rootname, 0);
                        if (result != ISC_R_SUCCESS) {
                                cfg_obj_log(identity, ISC_LOG_ERROR,
                                            "'%s' is not a valid name", str);
@@ -518,7 +518,7 @@ configure_staticstub_servernames(const cfg_obj_t *zconfig, dns_zone_t *zone,
 
                isc_buffer_constinit(&b, str, strlen(str));
                isc_buffer_add(&b, strlen(str));
-               result = dns_name_fromtext(nsname, &b, dns_rootname, 0, NULL);
+               result = dns_name_fromtext(nsname, &b, dns_rootname, 0);
                if (result != ISC_R_SUCCESS) {
                        cfg_obj_log(zconfig, ISC_LOG_ERROR,
                                    "server-name '%s' is not a valid "
index 8d8695582808c00d9a4099495e44ca58adaf75d7..f09c74db0b79cd44f94144a39d00d979cac735dc 100644 (file)
@@ -523,8 +523,7 @@ setup_keystr(void) {
        isc_buffer_add(&keynamesrc, (unsigned int)(n - name));
 
        debug("namefromtext");
-       result = dns_name_fromtext(mykeyname, &keynamesrc, dns_rootname, 0,
-                                  NULL);
+       result = dns_name_fromtext(mykeyname, &keynamesrc, dns_rootname, 0);
        check_result(result, "dns_name_fromtext");
 
        secretlen = strlen(secretstr) * 3 / 4;
@@ -793,7 +792,7 @@ create_name(const char *str, dns_name_t *name) {
        isc_buffer_add(&namesrc, strlen(str));
 
        return dns_name_fromtext(name, &namesrc, dns_rootname,
-                                DNS_NAME_DOWNCASE, NULL);
+                                DNS_NAME_DOWNCASE);
 }
 
 static void
@@ -1305,7 +1304,7 @@ parse_name(char **cmdlinep, dns_message_t *msg, dns_name_t **namep) {
        dns_message_gettempname(msg, namep);
        isc_buffer_init(&source, word, strlen(word));
        isc_buffer_add(&source, strlen(word));
-       result = dns_name_fromtext(*namep, &source, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(*namep, &source, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                error("invalid owner name: %s", isc_result_totext(result));
                isc_buffer_invalidate(&source);
@@ -1731,7 +1730,7 @@ evaluate_key(char *cmdline) {
 
        isc_buffer_init(&b, namestr, strlen(namestr));
        isc_buffer_add(&b, strlen(namestr));
-       result = dns_name_fromtext(mykeyname, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(mykeyname, &b, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                fprintf(stderr, "could not parse key name\n");
                return STATUS_SYNTAX;
@@ -1785,7 +1784,7 @@ evaluate_zone(char *cmdline) {
        userzone = dns_fixedname_initname(&fuserzone);
        isc_buffer_init(&b, word, strlen(word));
        isc_buffer_add(&b, strlen(word));
-       result = dns_name_fromtext(userzone, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(userzone, &b, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                userzone = NULL; /* Lest it point to an invalid name */
                fprintf(stderr, "could not parse zone name\n");
@@ -3119,7 +3118,7 @@ start_gssrequest(dns_name_t *primary) {
        RUNTIME_CHECK(result < sizeof(servicename));
        isc_buffer_init(&buf, servicename, strlen(servicename));
        isc_buffer_add(&buf, strlen(servicename));
-       result = dns_name_fromtext(servname, &buf, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(servname, &buf, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                fatal("dns_name_fromtext(servname) failed: %s",
                      isc_result_totext(result));
@@ -3136,7 +3135,7 @@ start_gssrequest(dns_name_t *primary) {
        isc_buffer_init(&buf, mykeystr, strlen(mykeystr));
        isc_buffer_add(&buf, strlen(mykeystr));
 
-       result = dns_name_fromtext(keyname, &buf, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(keyname, &buf, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                fatal("dns_name_fromtext(keyname) failed: %s",
                      isc_result_totext(result));
@@ -3295,7 +3294,7 @@ recvgss(void *arg) {
        servname = dns_fixedname_initname(&fname);
        isc_buffer_init(&buf, servicename, strlen(servicename));
        isc_buffer_add(&buf, strlen(servicename));
-       result = dns_name_fromtext(servname, &buf, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(servname, &buf, dns_rootname, 0);
        check_result(result, "dns_name_fromtext");
 
        result = dns_tkey_gssnegotiate(tsigquery, rcvmsg, servname, &context,
index fcfb50ccd021c42aeac33f88133b3499cd8cb993..fd1f03a31d06e6d7a0c0fb17bb3f7f539453d6ce 100644 (file)
@@ -141,7 +141,7 @@ sendquery(void) {
        isc_buffer_init(&buf, host, strlen(host));
        isc_buffer_add(&buf, strlen(host));
        result = dns_name_fromtext(dns_fixedname_name(&queryname), &buf,
-                                  dns_rootname, 0, NULL);
+                                  dns_rootname, 0);
        CHECK("dns_name_fromtext", result);
 
        dns_message_create(mctx, NULL, NULL, DNS_MESSAGE_INTENTRENDER,
index 3ae513b6681ebeddf28cc7c7442cf2b0814700f0..cafaf482c97ded4e3fce71c69116230811551bf5 100644 (file)
@@ -592,7 +592,7 @@ sendquery(struct query *query) {
        isc_buffer_init(&buf, query->textname, strlen(query->textname));
        isc_buffer_add(&buf, strlen(query->textname));
        result = dns_name_fromtext(dns_fixedname_name(&queryname), &buf,
-                                  dns_rootname, 0, NULL);
+                                  dns_rootname, 0);
        CHECK("dns_name_fromtext", result);
 
        dns_message_create(mctx, NULL, NULL, DNS_MESSAGE_INTENTRENDER,
index c0f62375d8065745e41933371173fec52a411ede..e55800821e7f8c9a666cd4f3459b64a9528174ea 100644 (file)
@@ -122,7 +122,7 @@ nsec3hash(nsec3printer *nsec3print, const char *algostr, const char *flagstr,
        name = dns_fixedname_initname(&fixed);
        isc_buffer_constinit(&buffer, domain, strlen(domain));
        isc_buffer_add(&buffer, strlen(domain));
-       result = dns_name_fromtext(name, &buffer, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name, &buffer, dns_rootname, 0);
        check_result(result, "dns_name_fromtext() failed");
 
        dns_name_downcase(name, name);
index 7886b0437157fc75c368a3e2f9bfbfa0125a6216..cdf6e479930787ab0f1f24f1e7f75088bf2ae9c7 100644 (file)
@@ -42,7 +42,7 @@ LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
        isc_buffer_setactive(&buf, size);
 
        result = dns_name_fromtext(dns_fixedname_name(&origin), &buf,
-                                  dns_rootname, 0, NULL);
+                                  dns_rootname, 0);
        if (debug) {
                fprintf(stderr, "dns_name_fromtext: %s\n",
                        isc_result_totext(result));
index a0a83c9ec4fff28797960ed1b8c068d909c7757f..fff186746e8c62d431e211ce8968c36318d776f5 100644 (file)
@@ -80,5 +80,5 @@ dns_byaddr_createptrname(const isc_netaddr_t *address, dns_name_t *name) {
        len = (unsigned int)strlen(textname);
        isc_buffer_init(&buffer, textname, len);
        isc_buffer_add(&buffer, len);
-       return dns_name_fromtext(name, &buffer, dns_rootname, 0, NULL);
+       return dns_name_fromtext(name, &buffer, dns_rootname, 0);
 }
index b6d41678edd3d7c2942bac91dda6a126f866fea9..599520092eab08bdcdc91e75713b59d7e252e580 100644 (file)
@@ -410,7 +410,7 @@ dns_dlz_writeablezone(dns_view_t *view, dns_dlzdb_t *dlzdb,
        isc_buffer_add(&buffer, strlen(zone_name));
        dns_fixedname_init(&fixorigin);
        result = dns_name_fromtext(dns_fixedname_name(&fixorigin), &buffer,
-                                  dns_rootname, 0, NULL);
+                                  dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                goto cleanup;
        }
index 7e8f4d2cb9581066418d3cdd56062c7eebb1c237..444eb8fbfd9342b203e51de6b53dfa336ec1fa51 100644 (file)
@@ -1618,8 +1618,7 @@ dst_key_read_public(const char *filename, int type, isc_mem_t *mctx,
        dns_fixedname_init(&name);
        isc_buffer_init(&b, DST_AS_STR(token), strlen(DST_AS_STR(token)));
        isc_buffer_add(&b, strlen(DST_AS_STR(token)));
-       ret = dns_name_fromtext(dns_fixedname_name(&name), &b, dns_rootname, 0,
-                               NULL);
+       ret = dns_name_fromtext(dns_fixedname_name(&name), &b, dns_rootname, 0);
        if (ret != ISC_R_SUCCESS) {
                goto cleanup;
        }
index 273d94a2cdb514b44195fc3367ea4df99c97833f..8e9025d3570cf1576d276a45baf8d6bd0c42c20d 100644 (file)
@@ -783,8 +783,7 @@ dst_gssapi_acceptctx(dns_gss_cred_id_t cred, const char *gssapi_keytab,
                isc_buffer_init(&namebuf, r.base, r.length);
                isc_buffer_add(&namebuf, r.length);
 
-               RETERR(dns_name_fromtext(principal, &namebuf, dns_rootname, 0,
-                                        NULL));
+               RETERR(dns_name_fromtext(principal, &namebuf, dns_rootname, 0));
 
                if (gnamebuf.length != 0U) {
                        gret = gss_release_buffer(&minor, &gnamebuf);
index 320e36b2eae889216dac0f406a4af7a8d51a2c8f..cf452104e00066ae257cd154e788838117e2df7b 100644 (file)
@@ -799,11 +799,10 @@ dns_name_towire(const dns_name_t *name, dns_compress_t *cctx,
 
 isc_result_t
 dns_name_fromtext(dns_name_t *name, isc_buffer_t *source,
-                 const dns_name_t *origin, unsigned int options,
-                 isc_buffer_t *target);
+                 const dns_name_t *origin, unsigned int options);
 /*%<
- * Convert the textual representation of a DNS name at source
- * into uncompressed wire form stored in target.
+ * Convert the textual representation of a DNS name in 'source'
+ * and store it in 'name'.
  *
  * Notes:
  * \li Relative domain names will have 'origin' appended to them
@@ -815,18 +814,52 @@ dns_name_fromtext(dns_name_t *name, isc_buffer_t *source,
  *
  * Requires:
  *
- * \li 'name' is a valid name.
+ * \li 'name' is a valid name with a dedicated buffer.
  *
  * \li 'source' is a valid buffer.
  *
- * \li 'target' is a valid buffer or 'target' is NULL and 'name' has
- *     a dedicated buffer.
- *
  * Ensures:
  *
  *     If result is success:
- * \li         If 'target' is not NULL, 'name' is attached to it.
+ * \li         Uppercase letters are downcased in the copy iff
+ *             DNS_NAME_DOWNCASE is set in 'options'.
  *
+ * \li         The current location in source is advanced.
+ *
+ * Result:
+ *\li  #ISC_R_SUCCESS
+ *\li  #DNS_R_EMPTYLABEL
+ *\li  #DNS_R_LABELTOOLONG
+ *\li  #DNS_R_BADESCAPE
+ *\li  #DNS_R_BADDOTTEDQUAD
+ *\li  #ISC_R_NOSPACE
+ *\li  #ISC_R_UNEXPECTEDEND
+ */
+
+isc_result_t
+dns_name_wirefromtext(isc_buffer_t *source, const dns_name_t *origin,
+                     unsigned int options, isc_buffer_t *target);
+/*%<
+ * Convert the textual representation of a DNS name in 'source'
+ * into uncompressed wire form stored in target.
+ *
+ * Notes:
+ * \li Relative domain names will have 'origin' appended to them
+ *     unless 'origin' is NULL, in which case relative domain names
+ *     will remain relative.
+ *
+ * \li If DNS_NAME_DOWNCASE is set in 'options', any uppercase letters
+ *     in 'source' will be downcased when they are copied into 'target'.
+ *
+ * Requires:
+ *
+ * \li 'source' is a valid buffer.
+ *
+ * \li 'target' is a valid buffer.
+ *
+ * Ensures:
+ *
+ *     If result is success:
  * \li         Uppercase letters are downcased in the copy iff
  *             DNS_NAME_DOWNCASE is set in 'options'.
  *
index 08b3a49046d5d8032ac16cf465ab74369c6e3903..071c1c3475f62f3f162de824079d130d31313abf 100644 (file)
@@ -835,8 +835,7 @@ generate(dns_loadctx_t *lctx, char *range, char *lhs, char *gtype, char *rhs,
                isc_buffer_init(&buffer, lhsbuf, strlen(lhsbuf));
                isc_buffer_add(&buffer, strlen(lhsbuf));
                isc_buffer_setactive(&buffer, strlen(lhsbuf));
-               result = dns_name_fromtext(owner, &buffer, ictx->origin, 0,
-                                          NULL);
+               result = dns_name_fromtext(owner, &buffer, ictx->origin, 0);
                if (result != ISC_R_SUCCESS) {
                        goto error_cleanup;
                }
@@ -1388,7 +1387,7 @@ load_text(dns_loadctx_t *lctx) {
                        isc_buffer_setactive(&buffer,
                                             token.value.as_region.length);
                        result = dns_name_fromtext(new_name, &buffer,
-                                                  ictx->origin, 0, NULL);
+                                                  ictx->origin, 0);
                        if (MANYERRS(lctx, result)) {
                                SETRESULT(lctx, result);
                                LOGIT(result);
index 193c25e31039f44938357ecc451d46f31713204f..2641b536ac48cf5d96cc96bc674adb75c01ae47f 100644 (file)
@@ -706,12 +706,11 @@ dns_name_fromregion(dns_name_t *name, const isc_region_t *r) {
        }
 }
 
-isc_result_t
-dns_name_fromtext(dns_name_t *name, isc_buffer_t *source,
-                 const dns_name_t *origin, unsigned int options,
-                 isc_buffer_t *target) {
-       unsigned char *ndata, *label = NULL;
-       char *tdata;
+static isc_result_t
+convert_text(isc_buffer_t *source, const dns_name_t *origin,
+            unsigned int options, dns_name_t *name, isc_buffer_t *target) {
+       unsigned char *ndata = NULL, *label = NULL;
+       char *tdata = NULL;
        char c;
        ft_state state;
        unsigned int value = 0, count = 0;
@@ -720,20 +719,9 @@ dns_name_fromtext(dns_name_t *name, isc_buffer_t *source,
        bool done;
        bool downcase;
 
-       /*
-        * Convert the textual representation of a DNS name at source
-        * into uncompressed wire form stored in target.
-        *
-        * Notes:
-        *      Relative domain names will have 'origin' appended to them
-        *      unless 'origin' is NULL, in which case relative domain names
-        *      will remain relative.
-        */
-
        REQUIRE(DNS_NAME_VALID(name));
        REQUIRE(ISC_BUFFER_VALID(source));
-       REQUIRE((target != NULL && ISC_BUFFER_VALID(target)) ||
-               (target == NULL && ISC_BUFFER_VALID(name->buffer)));
+       REQUIRE(ISC_BUFFER_VALID(target));
 
        downcase = ((options & DNS_NAME_DOWNCASE) != 0);
 
@@ -951,6 +939,27 @@ dns_name_fromtext(dns_name_t *name, isc_buffer_t *source,
        return ISC_R_SUCCESS;
 }
 
+isc_result_t
+dns_name_wirefromtext(isc_buffer_t *source, const dns_name_t *origin,
+                     unsigned int options, isc_buffer_t *target) {
+       dns_name_t name;
+
+       REQUIRE(ISC_BUFFER_VALID(target));
+
+       dns_name_init(&name);
+       return convert_text(source, origin, options, &name, target);
+}
+
+isc_result_t
+dns_name_fromtext(dns_name_t *name, isc_buffer_t *source,
+                 const dns_name_t *origin, unsigned int options) {
+       REQUIRE(DNS_NAME_VALID(name));
+       REQUIRE(ISC_BUFFER_VALID(name->buffer));
+
+       isc_buffer_clear(name->buffer);
+       return convert_text(source, origin, options, name, name->buffer);
+}
+
 isc_result_t
 dns_name_totext(const dns_name_t *name, unsigned int options,
                isc_buffer_t *target) {
@@ -1787,7 +1796,7 @@ dns_name_fromstring(dns_name_t *target, const char *src,
                name = dns_fixedname_initname(&fn);
        }
 
-       result = dns_name_fromtext(name, &buf, origin, options, NULL);
+       result = dns_name_fromtext(name, &buf, origin, options);
        if (result != ISC_R_SUCCESS) {
                return result;
        }
index d0d3eadda7467ecd2cde19650a4e9dd8dec2176c..8791c4160558310b70b85466ddf73f0716403de6 100644 (file)
@@ -282,7 +282,7 @@ dns_nsec3_hashname(dns_fixedname_t *result,
        /* convert the hex to a domain name */
        dns_fixedname_init(result);
        return dns_name_fromtext(dns_fixedname_name(result), &namebuffer,
-                                origin, 0, NULL);
+                                origin, 0);
 }
 
 unsigned int
index 6d733d9636f8657774cb492e39af6cd4d8ae3c04..f633ab285f73219a6319a7b4c5786b4d647a2ab9 100644 (file)
@@ -506,7 +506,7 @@ dns_peer_setkeybycharp(dns_peer_t *peer, const char *keyval) {
        isc_buffer_constinit(&b, keyval, strlen(keyval));
        isc_buffer_add(&b, strlen(keyval));
        result = dns_name_fromtext(dns_fixedname_name(&fname), &b, dns_rootname,
-                                  0, NULL);
+                                  0);
        if (result != ISC_R_SUCCESS) {
                return result;
        }
index e356840d933d73f0edaee4b42ef9aa32c4bee6e1..ef776e5562b0dfb276082258b22dcec37a3487b8 100644 (file)
@@ -20,7 +20,6 @@
 static isc_result_t
 fromtext_any_tsig(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        uint64_t sigtime;
        isc_buffer_t buffer;
        dns_rcode_t rcode;
@@ -39,12 +38,11 @@ fromtext_any_tsig(ARGS_FROMTEXT) {
         */
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
 
        /*
         * Time Signed: 48 bits.
index 99c9334c406c75484eeb33233f41a441d1d3917b..95a02fe957659d0f166806cca89f39fa8d290926 100644 (file)
@@ -24,7 +24,8 @@
 static isc_result_t
 fromtext_ch_a(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
+       dns_fixedname_t fn;
+       dns_name_t *name = dns_fixedname_initname(&fn);
        isc_buffer_t buffer;
 
        REQUIRE(type == dns_rdatatype_a);
@@ -37,22 +38,22 @@ fromtext_ch_a(ARGS_FROMTEXT) {
                                      false));
 
        /* get domain name */
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_fromtext(name, &buffer, origin, options));
+       RETTOK(dns_name_towire(name, NULL, target));
        if ((options & DNS_RDATA_CHECKNAMES) != 0 &&
            (options & DNS_RDATA_CHECKREVERSE) != 0)
        {
                bool ok;
-               ok = dns_name_ishostname(&name, false);
+               ok = dns_name_ishostname(name, false);
                if (!ok && (options & DNS_RDATA_CHECKNAMESFAIL) != 0) {
                        RETTOK(DNS_R_BADNAME);
                }
                if (!ok && callbacks != NULL) {
-                       warn_badname(&name, lexer, callbacks);
+                       warn_badname(name, lexer, callbacks);
                }
        }
 
index 25bd2e0b69fea201ddee816049b989ee31d3b5d4..0721610807643027f434eb739cf316f96f019590 100644 (file)
@@ -22,7 +22,8 @@ static isc_result_t
 fromtext_afsdb(ARGS_FROMTEXT) {
        isc_token_t token;
        isc_buffer_t buffer;
-       dns_name_t name;
+       dns_fixedname_t fn;
+       dns_name_t *name = dns_fixedname_initname(&fn);
        bool ok;
 
        REQUIRE(type == dns_rdatatype_afsdb);
@@ -46,21 +47,21 @@ fromtext_afsdb(ARGS_FROMTEXT) {
         */
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_fromtext(name, &buffer, origin, options));
+       RETTOK(dns_name_towire(name, NULL, target));
        ok = true;
        if ((options & DNS_RDATA_CHECKNAMES) != 0) {
-               ok = dns_name_ishostname(&name, false);
+               ok = dns_name_ishostname(name, false);
        }
        if (!ok && (options & DNS_RDATA_CHECKNAMESFAIL) != 0) {
                RETTOK(DNS_R_BADNAME);
        }
        if (!ok && callbacks != NULL) {
-               warn_badname(&name, lexer, callbacks);
+               warn_badname(name, lexer, callbacks);
        }
        return ISC_R_SUCCESS;
 }
index 1bd7378745ceed982bb0e7c476d51690a45a8507..00c66c7bf6c757a05e5537e75d8694571909f9dd 100644 (file)
@@ -23,7 +23,6 @@
 static isc_result_t
 fromtext_amtrelay(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
        unsigned int discovery;
        unsigned int gateway;
@@ -108,13 +107,11 @@ fromtext_amtrelay(ARGS_FROMTEXT) {
                return ISC_R_SUCCESS;
 
        case 3:
-               dns_name_init(&name);
                buffer_fromregion(&buffer, &token.value.as_region);
                if (origin == NULL) {
                        origin = dns_rootname;
                }
-               return dns_name_fromtext(&name, &buffer, origin, options,
-                                        target);
+               return dns_name_wirefromtext(&buffer, origin, options, target);
        default:
                UNREACHABLE();
        }
index a946097be6912249d777104a888e439397abb8f3..dbf333effb679803b5b0f3fa3dc32c49a2de6c8b 100644 (file)
@@ -20,7 +20,6 @@
 static isc_result_t
 fromtext_cname(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
 
        REQUIRE(type == dns_rdatatype_cname);
@@ -32,12 +31,11 @@ fromtext_cname(ARGS_FROMTEXT) {
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
 
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
        return ISC_R_SUCCESS;
 }
 
index ce87676a1e8e77c1470a45fee5d2a653dbc6eb52..6e1d6e14d2a87701afded6e1631a43553978ca8a 100644 (file)
@@ -21,7 +21,6 @@
 static isc_result_t
 fromtext_dname(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
 
        REQUIRE(type == dns_rdatatype_dname);
@@ -33,12 +32,11 @@ fromtext_dname(ARGS_FROMTEXT) {
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
 
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
        return ISC_R_SUCCESS;
 }
 
index 228922ba9252724bfa7fbd89c3295a38fca553e5..b084a899ebfaaad24d6c59fb7469fb1705182b5f 100644 (file)
@@ -20,7 +20,6 @@
 static isc_result_t
 fromtext_hip(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
        isc_buffer_t hit_len;
        isc_buffer_t key_len;
@@ -96,7 +95,6 @@ fromtext_hip(ARGS_FROMTEXT) {
        /*
         * Rendezvous Servers.
         */
-       dns_name_init(&name);
        do {
                RETERR(isc_lex_getmastertoken(lexer, &token,
                                              isc_tokentype_string, true));
@@ -104,8 +102,7 @@ fromtext_hip(ARGS_FROMTEXT) {
                        break;
                }
                buffer_fromregion(&buffer, &token.value.as_region);
-               RETTOK(dns_name_fromtext(&name, &buffer, origin, options,
-                                        target));
+               RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
        } while (1);
 
        /*
index d479e7d2d93d0eee3acb539550ce8e0a05f5a77e..4c4996c4bbdca148c998298ad31161b977af92eb 100644 (file)
@@ -23,7 +23,6 @@
 static isc_result_t
 fromtext_ipseckey(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
        unsigned int gateway;
        struct in_addr addr;
@@ -105,13 +104,11 @@ fromtext_ipseckey(ARGS_FROMTEXT) {
                break;
 
        case 3:
-               dns_name_init(&name);
                buffer_fromregion(&buffer, &token.value.as_region);
                if (origin == NULL) {
                        origin = dns_rootname;
                }
-               RETTOK(dns_name_fromtext(&name, &buffer, origin, options,
-                                        target));
+               RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
                break;
        }
 
index 6bc41e298d00178c4f5b2c8be3cc39923622a5f5..00aa6abc9031ba5e946592710b3ccbf86d053e4e 100644 (file)
@@ -23,7 +23,6 @@
 static isc_result_t
 fromtext_lp(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
 
        REQUIRE(type == dns_rdatatype_lp);
@@ -42,12 +41,11 @@ fromtext_lp(ARGS_FROMTEXT) {
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
 
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       return dns_name_fromtext(&name, &buffer, origin, options, target);
+       return dns_name_wirefromtext(&buffer, origin, options, target);
 }
 
 static isc_result_t
index ab6ab42b0cdab130fade91db43f1e64d6ae28b1e..555d92a51475f517ff0d2323c0be6b66e4e9049d 100644 (file)
@@ -19,7 +19,6 @@
 static isc_result_t
 fromtext_mb(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
 
        REQUIRE(type == dns_rdatatype_mb);
@@ -31,12 +30,11 @@ fromtext_mb(ARGS_FROMTEXT) {
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
 
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
        return ISC_R_SUCCESS;
 }
 
index 702b60c1852f045229bffdf8f3275abda873531c..217fd3b0bf1000cfafffaa9b5c5b57142610684d 100644 (file)
@@ -19,7 +19,6 @@
 static isc_result_t
 fromtext_md(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
 
        REQUIRE(type == dns_rdatatype_md);
@@ -31,12 +30,11 @@ fromtext_md(ARGS_FROMTEXT) {
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
 
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
        return ISC_R_SUCCESS;
 }
 
index 0142c124785d7221eccf0e6d61f8ffcacf0b3a28..8f353bf717c30afd5db956f63777273fdf960b21 100644 (file)
@@ -19,7 +19,6 @@
 static isc_result_t
 fromtext_mf(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
 
        REQUIRE(type == dns_rdatatype_mf);
@@ -31,12 +30,11 @@ fromtext_mf(ARGS_FROMTEXT) {
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
 
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
        return ISC_R_SUCCESS;
 }
 
index 0c8fae21c942b200f0cc8903eb2d293e4c06edbc..15dba05c01148df40f4407aa6896ae17d64a275c 100644 (file)
@@ -19,7 +19,6 @@
 static isc_result_t
 fromtext_mg(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
 
        REQUIRE(type == dns_rdatatype_mg);
@@ -31,12 +30,11 @@ fromtext_mg(ARGS_FROMTEXT) {
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
 
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
        return ISC_R_SUCCESS;
 }
 
index 7ea92d7c99121370a7f9490209b21ebe967a34f5..460d37c57375a61df3aea7240c599ed7e3d6d80a 100644 (file)
@@ -19,7 +19,8 @@
 static isc_result_t
 fromtext_minfo(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
+       dns_fixedname_t fn;
+       dns_name_t *name = dns_fixedname_initname(&fn);
        isc_buffer_t buffer;
        int i;
        bool ok;
@@ -37,19 +38,18 @@ fromtext_minfo(ARGS_FROMTEXT) {
        for (i = 0; i < 2; i++) {
                RETERR(isc_lex_getmastertoken(lexer, &token,
                                              isc_tokentype_string, false));
-               dns_name_init(&name);
                buffer_fromregion(&buffer, &token.value.as_region);
-               RETTOK(dns_name_fromtext(&name, &buffer, origin, options,
-                                        target));
+               RETTOK(dns_name_fromtext(name, &buffer, origin, options));
+               RETTOK(dns_name_towire(name, NULL, target));
                ok = true;
                if ((options & DNS_RDATA_CHECKNAMES) != 0) {
-                       ok = dns_name_ismailbox(&name);
+                       ok = dns_name_ismailbox(name);
                }
                if (!ok && (options & DNS_RDATA_CHECKNAMESFAIL) != 0) {
                        RETTOK(DNS_R_BADNAME);
                }
                if (!ok && callbacks != NULL) {
-                       warn_badname(&name, lexer, callbacks);
+                       warn_badname(name, lexer, callbacks);
                }
        }
        return ISC_R_SUCCESS;
index 4e62678852ffbf665c1f35a81cd78564d217cbc8..df023d731ac0795ffd7aa532b7d174d09b4bfcef 100644 (file)
@@ -19,7 +19,6 @@
 static isc_result_t
 fromtext_mr(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
 
        REQUIRE(type == dns_rdatatype_mr);
@@ -31,12 +30,11 @@ fromtext_mr(ARGS_FROMTEXT) {
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
 
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
        return ISC_R_SUCCESS;
 }
 
index afa40e6309f5523374f374a31bf4b58ce2fd4086..84ffd0e4a56baa459e5430a9ea1a6bd374cbe2b5 100644 (file)
@@ -47,7 +47,8 @@ check_mx(isc_token_t *token) {
 static isc_result_t
 fromtext_mx(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
+       dns_fixedname_t fn;
+       dns_name_t *name = dns_fixedname_initname(&fn);
        isc_buffer_t buffer;
        bool ok;
 
@@ -77,21 +78,21 @@ fromtext_mx(ARGS_FROMTEXT) {
                warn_badmx(&token, lexer, callbacks);
        }
 
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_fromtext(name, &buffer, origin, options));
+       RETTOK(dns_name_towire(name, NULL, target));
        ok = true;
        if ((options & DNS_RDATA_CHECKNAMES) != 0) {
-               ok = dns_name_ishostname(&name, false);
+               ok = dns_name_ishostname(name, false);
        }
        if (!ok && (options & DNS_RDATA_CHECKNAMESFAIL) != 0) {
                RETTOK(DNS_R_BADNAME);
        }
        if (!ok && callbacks != NULL) {
-               warn_badname(&name, lexer, callbacks);
+               warn_badname(name, lexer, callbacks);
        }
        return ISC_R_SUCCESS;
 }
index 3715bbcbe3d75c1d786748c21b8b639168eda3da..7589106c6a03173c1b152ea4d2bfd1372ece1020 100644 (file)
@@ -172,7 +172,6 @@ txt_valid_regex(const unsigned char *txt) {
 static isc_result_t
 fromtext_naptr(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
        unsigned char *regex;
 
@@ -230,12 +229,11 @@ fromtext_naptr(ARGS_FROMTEXT) {
         */
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
        return ISC_R_SUCCESS;
 }
 
index b6b38f438850262837522f3e13e7321a9a02b944..89362b6c83f66394b7042cea2e918cfef5a6997e 100644 (file)
@@ -19,7 +19,8 @@
 static isc_result_t
 fromtext_ns(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
+       dns_fixedname_t fn;
+       dns_name_t *name = dns_fixedname_initname(&fn);
        isc_buffer_t buffer;
        bool ok;
 
@@ -32,21 +33,21 @@ fromtext_ns(ARGS_FROMTEXT) {
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
 
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_fromtext(name, &buffer, origin, options));
+       RETTOK(dns_name_towire(name, NULL, target));
        ok = true;
        if ((options & DNS_RDATA_CHECKNAMES) != 0) {
-               ok = dns_name_ishostname(&name, false);
+               ok = dns_name_ishostname(name, false);
        }
        if (!ok && (options & DNS_RDATA_CHECKNAMESFAIL) != 0) {
                RETTOK(DNS_R_BADNAME);
        }
        if (!ok && callbacks != NULL) {
-               warn_badname(&name, lexer, callbacks);
+               warn_badname(name, lexer, callbacks);
        }
        return ISC_R_SUCCESS;
 }
index 28fea07c8225d25fc18d09459b9be9e4540e5a2c..e8858bb6d8d8c99dc0b6b13b977f244a7e4b0b74 100644 (file)
@@ -27,7 +27,6 @@
 static isc_result_t
 fromtext_nsec(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
 
        REQUIRE(type == dns_rdatatype_nsec);
@@ -41,12 +40,11 @@ fromtext_nsec(ARGS_FROMTEXT) {
         */
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
 
        return typemap_fromtext(lexer, target, false);
 }
index a552276292cff9acb4cab4efc25be744eb3a43b3..077bd73f5ac8f07e14f8a3cec3c8c6b4afc16280 100644 (file)
@@ -25,7 +25,6 @@
 static isc_result_t
 fromtext_nxt(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
        char *e;
        unsigned char bm[8 * 1024]; /* 64k bits */
@@ -45,12 +44,11 @@ fromtext_nxt(ARGS_FROMTEXT) {
         */
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
 
        memset(bm, 0, sizeof(bm));
        do {
index 24d975a0b96eb5e4bba6b8115cbd760589ca18fd..e0b5ea6309c3bb4402818e63dd50d2ba9859f6ef 100644 (file)
@@ -19,8 +19,9 @@
 static isc_result_t
 fromtext_ptr(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
+       dns_fixedname_t fn;
+       dns_name_t *name = dns_fixedname_initname(&fn);
 
        REQUIRE(type == dns_rdatatype_ptr);
 
@@ -31,23 +32,25 @@ fromtext_ptr(ARGS_FROMTEXT) {
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
 
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+
+       RETTOK(dns_name_fromtext(name, &buffer, origin, options));
+       RETTOK(dns_name_towire(name, NULL, target));
+
        if (rdclass == dns_rdataclass_in &&
            (options & DNS_RDATA_CHECKNAMES) != 0 &&
            (options & DNS_RDATA_CHECKREVERSE) != 0)
        {
                bool ok;
-               ok = dns_name_ishostname(&name, false);
+               ok = dns_name_ishostname(name, false);
                if (!ok && (options & DNS_RDATA_CHECKNAMESFAIL) != 0) {
                        RETTOK(DNS_R_BADNAME);
                }
                if (!ok && callbacks != NULL) {
-                       warn_badname(&name, lexer, callbacks);
+                       warn_badname(name, lexer, callbacks);
                }
        }
        return ISC_R_SUCCESS;
index 33c8192fac2c2df383bf006e1d0642f5b2d84e14..bc1861e9881da7a24a3d4a34307a05117cfcfc2e 100644 (file)
@@ -21,7 +21,6 @@
 static isc_result_t
 fromtext_rp(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
        int i;
        bool ok;
@@ -37,21 +36,25 @@ fromtext_rp(ARGS_FROMTEXT) {
        }
 
        for (i = 0; i < 2; i++) {
+               dns_fixedname_t fn;
+               dns_name_t *name = dns_fixedname_initname(&fn);
+
                RETERR(isc_lex_getmastertoken(lexer, &token,
                                              isc_tokentype_string, false));
-               dns_name_init(&name);
                buffer_fromregion(&buffer, &token.value.as_region);
-               RETTOK(dns_name_fromtext(&name, &buffer, origin, options,
-                                        target));
+
+               RETTOK(dns_name_fromtext(name, &buffer, origin, options));
+               RETTOK(dns_name_towire(name, NULL, target));
+
                ok = true;
                if ((options & DNS_RDATA_CHECKNAMES) != 0 && i == 0) {
-                       ok = dns_name_ismailbox(&name);
+                       ok = dns_name_ismailbox(name);
                }
                if (!ok && (options & DNS_RDATA_CHECKNAMESFAIL) != 0) {
                        RETTOK(DNS_R_BADNAME);
                }
                if (!ok && callbacks != NULL) {
-                       warn_badname(&name, lexer, callbacks);
+                       warn_badname(name, lexer, callbacks);
                }
        }
        return ISC_R_SUCCESS;
index bcfac4a6669f476c429828738aee05b0a35e578a..91202513afd3727785b47a126f21f10c0aeb9c7a 100644 (file)
@@ -28,7 +28,6 @@ fromtext_rrsig(ARGS_FROMTEXT) {
        dns_rdatatype_t covered;
        char *e;
        isc_result_t result;
-       dns_name_t name;
        isc_buffer_t buffer;
        uint32_t time_signed, time_expire;
        unsigned int used;
@@ -145,12 +144,11 @@ fromtext_rrsig(ARGS_FROMTEXT) {
         */
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
 
        /*
         * Sig.
index 41c0df41f30834f46a2ae7b1d6b05f1da45641e4..798693f92b8f368f11bf2c03ee0bf0174502ec4d 100644 (file)
@@ -21,8 +21,9 @@
 static isc_result_t
 fromtext_rt(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
+       dns_fixedname_t fn;
+       dns_name_t *name = dns_fixedname_initname(&fn);
        bool ok;
 
        REQUIRE(type == dns_rdatatype_rt);
@@ -41,21 +42,23 @@ fromtext_rt(ARGS_FROMTEXT) {
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
 
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+
+       RETTOK(dns_name_fromtext(name, &buffer, origin, options));
+       RETTOK(dns_name_towire(name, NULL, target));
+
        ok = true;
        if ((options & DNS_RDATA_CHECKNAMES) != 0) {
-               ok = dns_name_ishostname(&name, false);
+               ok = dns_name_ishostname(name, false);
        }
        if (!ok && (options & DNS_RDATA_CHECKNAMESFAIL) != 0) {
                RETTOK(DNS_R_BADNAME);
        }
        if (!ok && callbacks != NULL) {
-               warn_badname(&name, lexer, callbacks);
+               warn_badname(name, lexer, callbacks);
        }
        return ISC_R_SUCCESS;
 }
index c5d3ed3ef7bb50dcb8070fee6ac8ac72fb87eccb..04b37fcd393c245cfc632092342e6367129eeb2d 100644 (file)
@@ -26,7 +26,6 @@ fromtext_sig(ARGS_FROMTEXT) {
        dns_rdatatype_t covered;
        char *e;
        isc_result_t result;
-       dns_name_t name;
        isc_buffer_t buffer;
        uint32_t time_signed, time_expire;
        unsigned int used;
@@ -109,12 +108,11 @@ fromtext_sig(ARGS_FROMTEXT) {
         */
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
 
        /*
         * Sig.
index 782da3c1a84ac6c06e2d70979a50b821e1c2c732..427433ee28bb6149ca157445fa5fd8b5ab224339 100644 (file)
@@ -19,7 +19,6 @@
 static isc_result_t
 fromtext_soa(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
        int i;
        uint32_t n;
@@ -36,21 +35,23 @@ fromtext_soa(ARGS_FROMTEXT) {
        }
 
        for (i = 0; i < 2; i++) {
+               dns_fixedname_t fn;
+               dns_name_t *name = dns_fixedname_initname(&fn);
+
                RETERR(isc_lex_getmastertoken(lexer, &token,
                                              isc_tokentype_string, false));
 
-               dns_name_init(&name);
                buffer_fromregion(&buffer, &token.value.as_region);
-               RETTOK(dns_name_fromtext(&name, &buffer, origin, options,
-                                        target));
+               RETTOK(dns_name_fromtext(name, &buffer, origin, options));
+               RETTOK(dns_name_towire(name, NULL, target));
                ok = true;
                if ((options & DNS_RDATA_CHECKNAMES) != 0) {
                        switch (i) {
                        case 0:
-                               ok = dns_name_ishostname(&name, false);
+                               ok = dns_name_ishostname(name, false);
                                break;
                        case 1:
-                               ok = dns_name_ismailbox(&name);
+                               ok = dns_name_ismailbox(name);
                                break;
                        }
                }
@@ -58,7 +59,7 @@ fromtext_soa(ARGS_FROMTEXT) {
                        RETTOK(DNS_R_BADNAME);
                }
                if (!ok && callbacks != NULL) {
-                       warn_badname(&name, lexer, callbacks);
+                       warn_badname(name, lexer, callbacks);
                }
        }
 
index 148a11569c2e3ab8570a7014fe4b7191acde0e92..fef1195b32254298054e43064771c35ff0457092 100644 (file)
@@ -19,7 +19,6 @@
 static isc_result_t
 fromtext_talink(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
        int i;
 
@@ -37,10 +36,8 @@ fromtext_talink(ARGS_FROMTEXT) {
                RETERR(isc_lex_getmastertoken(lexer, &token,
                                              isc_tokentype_string, false));
 
-               dns_name_init(&name);
                buffer_fromregion(&buffer, &token.value.as_region);
-               RETTOK(dns_name_fromtext(&name, &buffer, origin, options,
-                                        target));
+               RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
        }
 
        return ISC_R_SUCCESS;
index dbea25a1da18dfa1f24bc573f3ac24477d476bbd..b16757b3ada64dbceed3994628cd3b3fb699575e 100644 (file)
@@ -22,7 +22,6 @@ static isc_result_t
 fromtext_tkey(ARGS_FROMTEXT) {
        isc_token_t token;
        dns_rcode_t rcode;
-       dns_name_t name;
        isc_buffer_t buffer;
        long i;
        char *e;
@@ -38,12 +37,11 @@ fromtext_tkey(ARGS_FROMTEXT) {
         */
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
 
        /*
         * Inception.
index b70a65343f3a0312bb6c8ec6c1b50efce331ee05..822f9b225beef766af28b27e20b7a21b2d2a5d2d 100644 (file)
@@ -27,8 +27,9 @@ fromtext_in_a6(ARGS_FROMTEXT) {
        unsigned char prefixlen;
        unsigned char octets;
        unsigned char mask;
-       dns_name_t name;
        isc_buffer_t buffer;
+       dns_fixedname_t fn;
+       dns_name_t *name = dns_fixedname_initname(&fn);
        bool ok;
 
        REQUIRE(type == dns_rdatatype_a6);
@@ -77,21 +78,23 @@ fromtext_in_a6(ARGS_FROMTEXT) {
 
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+
+       RETTOK(dns_name_fromtext(name, &buffer, origin, options));
+       RETTOK(dns_name_towire(name, NULL, target));
+
        ok = true;
        if ((options & DNS_RDATA_CHECKNAMES) != 0) {
-               ok = dns_name_ishostname(&name, false);
+               ok = dns_name_ishostname(name, false);
        }
        if (!ok && (options & DNS_RDATA_CHECKNAMESFAIL) != 0) {
                RETTOK(DNS_R_BADNAME);
        }
        if (!ok && callbacks != NULL) {
-               warn_badname(&name, lexer, callbacks);
+               warn_badname(name, lexer, callbacks);
        }
        return ISC_R_SUCCESS;
 }
index aebc7292a5683350ba8ad14cb099675b626d9d53..3498b72d2604d291b7848424df9c7b0bb208afc6 100644 (file)
@@ -21,7 +21,6 @@
 static isc_result_t
 fromtext_in_kx(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
 
        REQUIRE(type == dns_rdatatype_kx);
@@ -40,12 +39,11 @@ fromtext_in_kx(ARGS_FROMTEXT) {
 
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
        return ISC_R_SUCCESS;
 }
 
index 55167cebeec5310bc31a502745f29541b11e961d..929d3264221b5af1589d9911bd747dfb377b1f54 100644 (file)
@@ -21,7 +21,6 @@
 static isc_result_t
 fromtext_in_nsap_ptr(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
 
        REQUIRE(type == dns_rdatatype_nsap_ptr);
@@ -34,12 +33,11 @@ fromtext_in_nsap_ptr(ARGS_FROMTEXT) {
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
 
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
        return ISC_R_SUCCESS;
 }
 
index 1301767596996148786b1d0f8367e9113f31ee8a..89603478ed20ad96e46b5f0e18af5c5eec7c197d 100644 (file)
@@ -21,7 +21,6 @@
 static isc_result_t
 fromtext_in_px(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
 
        REQUIRE(type == dns_rdatatype_px);
@@ -50,18 +49,16 @@ fromtext_in_px(ARGS_FROMTEXT) {
         */
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
 
        /*
         * MAPX400.
         */
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_wirefromtext(&buffer, origin, options, target));
        return ISC_R_SUCCESS;
 }
 
index 0b8f34b53b3cc8095650ee4005abdeeb91c75d8b..5c0cb1ed7293b18322b987ea69f438ab1b1dc2f3 100644 (file)
@@ -21,8 +21,9 @@
 static isc_result_t
 fromtext_in_srv(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
+       dns_fixedname_t fn;
+       dns_name_t *name = dns_fixedname_initname(&fn);
        bool ok;
 
        REQUIRE(type == dns_rdatatype_srv);
@@ -67,22 +68,24 @@ fromtext_in_srv(ARGS_FROMTEXT) {
         */
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
                                      false));
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+       RETTOK(dns_name_fromtext(name, &buffer, origin, options));
+       RETTOK(dns_name_towire(name, NULL, target));
        ok = true;
+
        if ((options & DNS_RDATA_CHECKNAMES) != 0) {
-               ok = dns_name_ishostname(&name, false);
+               ok = dns_name_ishostname(name, false);
        }
        if (!ok && (options & DNS_RDATA_CHECKNAMESFAIL) != 0) {
                RETTOK(DNS_R_BADNAME);
        }
        if (!ok && callbacks != NULL) {
-               warn_badname(&name, lexer, callbacks);
+               warn_badname(name, lexer, callbacks);
        }
+
        return ISC_R_SUCCESS;
 }
 
index b2f239ef99c7bc7263ca0f6cd495f5f2b4dc04d2..0f458c9c0481d3b09c0441611cf628a377ab2229 100644 (file)
@@ -552,11 +552,12 @@ svcsortkeys(isc_buffer_t *target, unsigned int used) {
 static isc_result_t
 generic_fromtext_in_svcb(ARGS_FROMTEXT) {
        isc_token_t token;
-       dns_name_t name;
        isc_buffer_t buffer;
        bool alias;
        bool ok = true;
        unsigned int used;
+       dns_fixedname_t fn;
+       dns_name_t *name = dns_fixedname_initname(&fn);
 
        UNUSED(type);
        UNUSED(rdclass);
@@ -579,20 +580,22 @@ generic_fromtext_in_svcb(ARGS_FROMTEXT) {
         */
        RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_qstring,
                                      false));
-       dns_name_init(&name);
        buffer_fromregion(&buffer, &token.value.as_region);
        if (origin == NULL) {
                origin = dns_rootname;
        }
-       RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
+
+       RETTOK(dns_name_fromtext(name, &buffer, origin, options));
+       RETTOK(dns_name_towire(name, NULL, target));
+
        if (!alias && (options & DNS_RDATA_CHECKNAMES) != 0) {
-               ok = dns_name_ishostname(&name, false);
+               ok = dns_name_ishostname(name, false);
        }
        if (!ok && (options & DNS_RDATA_CHECKNAMESFAIL) != 0) {
                RETTOK(DNS_R_BADNAME);
        }
        if (!ok && callbacks != NULL) {
-               warn_badname(&name, lexer, callbacks);
+               warn_badname(name, lexer, callbacks);
        }
 
        /*
index 24a95af3d55f061271bc3655d264547ea3464a2c..42c7b286bac3fc586259269d8bd7b388541e3a0f 100644 (file)
@@ -818,7 +818,7 @@ ip2name(const dns_rpz_cidr_key_t *tgt_ip, dns_rpz_prefix_t tgt_prefix,
 
        isc_buffer_init(&buffer, str, sizeof(str));
        isc_buffer_add(&buffer, len);
-       result = dns_name_fromtext(ip_name, &buffer, base_name, 0, NULL);
+       result = dns_name_fromtext(ip_name, &buffer, base_name, 0);
        return result;
 }
 
index c65da7cd5e7c66dfc58ea8dc6890988d9ec12037..e99f34da13d57afed5c9f6d3b9773fe445e2cbf4 100644 (file)
@@ -1798,7 +1798,7 @@ dns_sdlz_putnamedrr(dns_sdlzallnodes_t *allnodes, const char *name,
        isc_buffer_constinit(&b, name, strlen(name));
        isc_buffer_add(&b, strlen(name));
 
-       result = dns_name_fromtext(newname, &b, origin, 0, NULL);
+       result = dns_name_fromtext(newname, &b, origin, 0);
        if (result != ISC_R_SUCCESS) {
                return result;
        }
index e2dada1f7906bc046b5b5cd04fc112435aae66c1..ee64025b34482122cf7e22a54b071698bd55a340 100644 (file)
@@ -72,7 +72,7 @@ parse_rr(isc_lex_t *lex, isc_mem_t *mctx, char *owner, dns_name_t *origin,
        dname = dns_fixedname_initname(&dfname);
        isc_buffer_init(&b, owner, strlen(owner));
        isc_buffer_add(&b, strlen(owner));
-       ret = dns_name_fromtext(dname, &b, dns_rootname, 0, NULL);
+       ret = dns_name_fromtext(dname, &b, dns_rootname, 0);
        if (ret != ISC_R_SUCCESS) {
                return ret;
        }
index 064930740060ec236ffcc20fc80b027bbd5798a2..29ca14ee688eaeb1b379007e7ad7260d807ed592 100644 (file)
@@ -278,7 +278,7 @@ reverse_from_address(dns_name_t *tcpself, const isc_netaddr_t *tcpaddr) {
        }
        isc_buffer_init(&b, buf, strlen(buf));
        isc_buffer_add(&b, strlen(buf));
-       result = dns_name_fromtext(tcpself, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(tcpself, &b, dns_rootname, 0);
        RUNTIME_CHECK(result == ISC_R_SUCCESS);
 }
 
@@ -318,7 +318,7 @@ stf_from_address(dns_name_t *stfself, const isc_netaddr_t *tcpaddr) {
        }
        isc_buffer_init(&b, buf, strlen(buf));
        isc_buffer_add(&b, strlen(buf));
-       result = dns_name_fromtext(stfself, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(stfself, &b, dns_rootname, 0);
        RUNTIME_CHECK(result == ISC_R_SUCCESS);
 }
 
index 377cdb9047a63f93465bc691e064fb4f6b757f41..ecfb21731d2a57aa8cd4a492dea07db8ae01baf0 100644 (file)
@@ -473,7 +473,7 @@ dns_tkey_processquery(dns_message_t *msg, dns_tkeyctx_t *tctx,
                        isc_nonce_buf(randomdata, sizeof(randomdata));
                        isc_buffer_init(&b, randomtext, sizeof(randomtext));
                        RETERR(isc_hex_totext(&r, 2, "", &b));
-                       RETERR(dns_name_fromtext(keyname, &b, NULL, 0, NULL));
+                       RETERR(dns_name_fromtext(keyname, &b, NULL, 0));
                }
                RETERR(dns_name_concatenate(keyname, dns_rootname, keyname));
 
index 828a4addf1eba7f06e8e298e9155ec3f67781a85..57da1846588cc26123221866ad8058ec53f2740d 100644 (file)
@@ -372,7 +372,7 @@ restore_key(dns_tsigkeyring_t *ring, isc_stdtime_t now, FILE *fp) {
        name = dns_fixedname_initname(&fname);
        isc_buffer_init(&b, namestr, strlen(namestr));
        isc_buffer_add(&b, strlen(namestr));
-       result = dns_name_fromtext(name, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name, &b, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                return result;
        }
@@ -380,7 +380,7 @@ restore_key(dns_tsigkeyring_t *ring, isc_stdtime_t now, FILE *fp) {
        creator = dns_fixedname_initname(&fcreator);
        isc_buffer_init(&b, creatorstr, strlen(creatorstr));
        isc_buffer_add(&b, strlen(creatorstr));
-       result = dns_name_fromtext(creator, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(creator, &b, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                return result;
        }
@@ -388,7 +388,7 @@ restore_key(dns_tsigkeyring_t *ring, isc_stdtime_t now, FILE *fp) {
        algorithm = dns_fixedname_initname(&falgorithm);
        isc_buffer_init(&b, algorithmstr, strlen(algorithmstr));
        isc_buffer_add(&b, strlen(algorithmstr));
-       result = dns_name_fromtext(algorithm, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(algorithm, &b, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                return result;
        }
index be7db571c858f9d689a4d80d0d65934d166b3a79..963d862723e71a74f93582628e47b133d7ad2a32 100644 (file)
@@ -2071,8 +2071,7 @@ dns_view_loadnta(dns_view_t *view) {
 
                        isc_buffer_init(&b, name, (unsigned int)len);
                        isc_buffer_add(&b, (unsigned int)len);
-                       CHECK(dns_name_fromtext(fname, &b, dns_rootname, 0,
-                                               NULL));
+                       CHECK(dns_name_fromtext(fname, &b, dns_rootname, 0));
                        ntaname = fname;
                }
 
index 10973151cc71d987546a886623eeba799110ada5..133322a0dfc1eb0bddee2e4db7030abe00abfc0b 100644 (file)
@@ -181,7 +181,7 @@ convert_keyname(const cfg_obj_t *keyobj, isc_mem_t *mctx, dns_name_t *dnsname) {
        isc_buffer_add(&buf, keylen);
        dns_fixedname_init(&fixname);
        result = dns_name_fromtext(dns_fixedname_name(&fixname), &buf,
-                                  dns_rootname, 0, NULL);
+                                  dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                cfg_obj_log(keyobj, ISC_LOG_WARNING,
                            "key name '%s' is not a valid domain name",
index c60eec4b676f9542813fe2c1a3c9ce4ca60e9625..2e8a4b22973a0114893e6f9865231384772bae61 100644 (file)
@@ -136,7 +136,7 @@ check_orderent(const cfg_obj_t *ent) {
                isc_buffer_constinit(&b, str, strlen(str));
                isc_buffer_add(&b, strlen(str));
                tresult = dns_name_fromtext(dns_fixedname_name(&fixed), &b,
-                                           dns_rootname, 0, NULL);
+                                           dns_rootname, 0);
                if (tresult != ISC_R_SUCCESS) {
                        cfg_obj_log(obj, ISC_LOG_ERROR,
                                    "rrset-order: invalid name '%s'", str);
@@ -243,8 +243,7 @@ check_dual_stack(const cfg_obj_t *options) {
                isc_buffer_constinit(&buffer, str, strlen(str));
                isc_buffer_add(&buffer, strlen(str));
                name = dns_fixedname_initname(&fixed);
-               tresult = dns_name_fromtext(name, &buffer, dns_rootname, 0,
-                                           NULL);
+               tresult = dns_name_fromtext(name, &buffer, dns_rootname, 0);
                if (tresult != ISC_R_SUCCESS) {
                        cfg_obj_log(obj, ISC_LOG_ERROR, "bad name '%s'", str);
                        if (result == ISC_R_SUCCESS) {
@@ -365,7 +364,7 @@ disabled_algorithms(const cfg_obj_t *disabled) {
        str = cfg_obj_asstring(obj);
        isc_buffer_constinit(&b, str, strlen(str));
        isc_buffer_add(&b, strlen(str));
-       tresult = dns_name_fromtext(name, &b, dns_rootname, 0, NULL);
+       tresult = dns_name_fromtext(name, &b, dns_rootname, 0);
        if (tresult != ISC_R_SUCCESS) {
                cfg_obj_log(obj, ISC_LOG_ERROR, "bad domain name '%s'", str);
                result = tresult;
@@ -408,7 +407,7 @@ disabled_ds_digests(const cfg_obj_t *disabled) {
        str = cfg_obj_asstring(obj);
        isc_buffer_constinit(&b, str, strlen(str));
        isc_buffer_add(&b, strlen(str));
-       tresult = dns_name_fromtext(name, &b, dns_rootname, 0, NULL);
+       tresult = dns_name_fromtext(name, &b, dns_rootname, 0);
        if (tresult != ISC_R_SUCCESS) {
                cfg_obj_log(obj, ISC_LOG_ERROR, "bad domain name '%s'", str);
                result = tresult;
@@ -3130,7 +3129,7 @@ check_zoneconf(const cfg_obj_t *zconfig, const cfg_obj_t *voptions,
        isc_buffer_constinit(&b, znamestr, strlen(znamestr));
        isc_buffer_add(&b, strlen(znamestr));
        tresult = dns_name_fromtext(dns_fixedname_name(&fixedname), &b,
-                                   dns_rootname, DNS_NAME_DOWNCASE, NULL);
+                                   dns_rootname, DNS_NAME_DOWNCASE);
        if (tresult != ISC_R_SUCCESS) {
                cfg_obj_log(zconfig, ISC_LOG_ERROR,
                            "zone '%s': is not a valid name", znamestr);
@@ -3718,8 +3717,8 @@ check_zoneconf(const cfg_obj_t *zconfig, const cfg_obj_t *voptions,
                        isc_buffer_constinit(&b2, snamestr, strlen(snamestr));
                        isc_buffer_add(&b2, strlen(snamestr));
                        sname = dns_fixedname_initname(&fixed_sname);
-                       tresult = dns_name_fromtext(sname, &b2, dns_rootname, 0,
-                                                   NULL);
+                       tresult = dns_name_fromtext(sname, &b2, dns_rootname,
+                                                   0);
                        if (tresult != ISC_R_SUCCESS) {
                                cfg_obj_log(zconfig, ISC_LOG_ERROR,
                                            "server-name '%s' is not a valid "
@@ -4153,7 +4152,7 @@ check_keylist(const cfg_obj_t *keys, isc_symtab_t *symtab, isc_mem_t *mctx) {
 
                isc_buffer_constinit(&b, keyid, strlen(keyid));
                isc_buffer_add(&b, strlen(keyid));
-               tresult = dns_name_fromtext(name, &b, dns_rootname, 0, NULL);
+               tresult = dns_name_fromtext(name, &b, dns_rootname, 0);
                if (tresult != ISC_R_SUCCESS) {
                        cfg_obj_log(key, ISC_LOG_ERROR,
                                    "key '%s': bad key name", keyid);
@@ -4393,7 +4392,7 @@ check_servers(const cfg_obj_t *config, const cfg_obj_t *voptions,
                        isc_buffer_add(&b, strlen(keyval));
                        keyname = dns_fixedname_initname(&fname);
                        tresult = dns_name_fromtext(keyname, &b, dns_rootname,
-                                                   0, NULL);
+                                                   0);
                        if (tresult != ISC_R_SUCCESS) {
                                cfg_obj_log(keys, ISC_LOG_ERROR,
                                            "bad key name '%s'", keyval);
@@ -4558,7 +4557,7 @@ check_trust_anchor(const cfg_obj_t *key, unsigned int *flagsp) {
        keyname = dns_fixedname_initname(&fkeyname);
        isc_buffer_constinit(&b, namestr, strlen(namestr));
        isc_buffer_add(&b, strlen(namestr));
-       result = dns_name_fromtext(keyname, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(keyname, &b, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                cfg_obj_log(key, ISC_LOG_WARNING, "bad key name: %s\n",
                            isc_result_totext(result));
index 31e73f5be100a97353d7b10011f7ca3c8762028a..912e8847e21f8ed20f886227428ce55038095185 100644 (file)
@@ -62,7 +62,7 @@ main(void) {
                        errx(1, "too many names");
                }
                dns_name_t *name = dns_fixedname_initname(&fixedname[count++]);
-               result = dns_name_fromtext(name, &buf, dns_rootname, 0, NULL);
+               result = dns_name_fromtext(name, &buf, dns_rootname, 0);
                CHECKRESULT(result, line);
        }
 
index ca9aa0ac3a0a31082ed694b5b5125b9efd37a13e..9957bbc543c186895dcb5bcdaa09a1eb98792a30 100644 (file)
@@ -471,8 +471,7 @@ main(int argc, char *argv[]) {
                isc_buffer_t buffer;
                isc_buffer_init(&buffer, domain, len);
                isc_buffer_add(&buffer, len);
-               result = dns_name_fromtext(name, &buffer, dns_rootname, 0,
-                                          NULL);
+               result = dns_name_fromtext(name, &buffer, dns_rootname, 0);
                FILE_CHECK(result == ISC_R_SUCCESS, isc_result_totext(result));
 
                wirebytes += name->length;
index 612a5b0446bf9783db7ae8db3a134f38407a42fa..476cab2bfc880268b59392b578b0dacad2c02102 100644 (file)
@@ -203,8 +203,7 @@ main(int argc, char *argv[]) {
 
                isc_buffer_init(&buffer, domain, len);
                isc_buffer_add(&buffer, len);
-               result = dns_name_fromtext(name, &buffer, dns_rootname, 0,
-                                          NULL);
+               result = dns_name_fromtext(name, &buffer, dns_rootname, 0);
                if (result == ISC_R_SUCCESS) {
                        smallname_from_name(name, &pval, &ival);
                        result = dns_qp_insert(qp, pval, ival);
index 23130caedd0f3a87e903343b5dd100014b77c258..ed31ecf318b79370677c0cd2da66e7f6030baf04 100644 (file)
@@ -162,8 +162,7 @@ load_qp(dns_qp_t *qp, const char *filename) {
 
                isc_buffer_init(&buffer, domain, len);
                isc_buffer_add(&buffer, len);
-               result = dns_name_fromtext(name, &buffer, dns_rootname, 0,
-                                          NULL);
+               result = dns_name_fromtext(name, &buffer, dns_rootname, 0);
                if (result == ISC_R_SUCCESS) {
                        smallname_from_name(name, &pval, &ival);
                        result = dns_qp_insert(qp, pval, ival);
index 67e19c71e55b9a352f58632350d66da6503ce9e1..a84e4d806cac9d02549c4d0acf3c7afe84fd0d32 100644 (file)
@@ -42,7 +42,7 @@ make_name(const char *src, dns_name_t *name) {
        isc_buffer_t b;
        isc_buffer_constinit(&b, src, strlen(src));
        isc_buffer_add(&b, strlen(src));
-       return dns_name_fromtext(name, &b, dns_rootname, 0, NULL);
+       return dns_name_fromtext(name, &b, dns_rootname, 0);
 }
 
 /* create: make sure we can create a dbiterator */
index c6c743f12ff125a023660724bbe4074ef57aaba7..ae3bed56db76000b83a3ea63d159e7b6c6209476 100644 (file)
@@ -219,7 +219,7 @@ setup_test(void **state) {
        isc_buffer_constinit(&namesrc, tls_name_str, strlen(tls_name_str));
        isc_buffer_add(&namesrc, strlen(tls_name_str));
        if (dns_name_fromtext(tls_name, &namesrc, dns_rootname,
-                             DNS_NAME_DOWNCASE, NULL) != ISC_R_SUCCESS)
+                             DNS_NAME_DOWNCASE) != ISC_R_SUCCESS)
        {
                return -1;
        }
index a7b1aaf5b0810056614c39d814ee606a177411c6..de88bd165588124cb427c9f5153a404cf18b4ab4 100644 (file)
@@ -180,7 +180,7 @@ ISC_LOOP_TEST_IMPL(dns_dt_send) {
        zname = dns_fixedname_initname(&zfname);
        isc_buffer_constinit(&zb, "example.com.", 12);
        isc_buffer_add(&zb, 12);
-       result = dns_name_fromtext(zname, &zb, NULL, 0, NULL);
+       result = dns_name_fromtext(zname, &zb, NULL, 0);
        assert_int_equal(result, ISC_R_SUCCESS);
 
        memset(&zr, 0, sizeof(zr));
index 871a4931ce50c3fef50a55e9ebdde1e3cbb9b8f4..10bb24bc9b8ac3e0c74b7c85ddb13544846227c8 100644 (file)
@@ -163,7 +163,7 @@ check_sig(const char *datapath, const char *sigpath, const char *keyname,
        name = dns_fixedname_initname(&fname);
        isc_buffer_constinit(&b, keyname, strlen(keyname));
        isc_buffer_add(&b, strlen(keyname));
-       result = dns_name_fromtext(name, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name, &b, dns_rootname, 0);
        assert_int_equal(result, ISC_R_SUCCESS);
        result = dst_key_fromfile(name, id, alg, type,
                                  TESTS_DIR "/testdata/dst", mctx, &key);
@@ -298,7 +298,7 @@ check_cmp(const char *key1_name, dns_keytag_t key1_id, const char *key2_name,
        name1 = dns_fixedname_initname(&fname1);
        isc_buffer_constinit(&b1, key1_name, strlen(key1_name));
        isc_buffer_add(&b1, strlen(key1_name));
-       result = dns_name_fromtext(name1, &b1, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name1, &b1, dns_rootname, 0);
        assert_int_equal(result, ISC_R_SUCCESS);
        result = dst_key_fromfile(name1, key1_id, alg, type,
                                  TESTS_DIR "/comparekeys", mctx, &key1);
@@ -310,7 +310,7 @@ check_cmp(const char *key1_name, dns_keytag_t key1_id, const char *key2_name,
        name2 = dns_fixedname_initname(&fname2);
        isc_buffer_constinit(&b2, key2_name, strlen(key2_name));
        isc_buffer_add(&b2, strlen(key2_name));
-       result = dns_name_fromtext(name2, &b2, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name2, &b2, dns_rootname, 0);
        assert_int_equal(result, ISC_R_SUCCESS);
        result = dst_key_fromfile(name2, key2_id, alg, type,
                                  TESTS_DIR "/comparekeys", mctx, &key2);
@@ -445,7 +445,7 @@ ISC_RUN_TEST_IMPL(ecdsa_determinism_test) {
        name = dns_fixedname_initname(&fname);
        isc_buffer_constinit(&keybuf, "example.", strlen("example."));
        isc_buffer_add(&keybuf, strlen("example."));
-       result = dns_name_fromtext(name, &keybuf, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name, &keybuf, dns_rootname, 0);
        assert_int_equal(result, ISC_R_SUCCESS);
        result = dst_key_fromfile(name, 19786, DST_ALG_ECDSA256,
                                  DST_TYPE_PUBLIC | DST_TYPE_PRIVATE,
index 5b0ba19a3af7f2d1879bc7445cbf74b70f18df89..538a98bfebb62b31840cc440ef2fbff63a4173ba 100644 (file)
@@ -97,9 +97,8 @@ str2name(const char *namestr) {
        name = dns_fixedname_initname(&fname);
        isc_buffer_init(&namebuf, UNCONST(namestr), strlen(namestr));
        isc_buffer_add(&namebuf, strlen(namestr));
-       assert_int_equal(
-               dns_name_fromtext(name, &namebuf, dns_rootname, 0, NULL),
-               ISC_R_SUCCESS);
+       assert_int_equal(dns_name_fromtext(name, &namebuf, dns_rootname, 0),
+                        ISC_R_SUCCESS);
 
        return name;
 }
index 6a2297876a4c4f5b2c5856d3ac95dd82d6ae82f8..930e339475fcc1e7d5d672d8c7787b1224cc2a6a 100644 (file)
@@ -100,7 +100,7 @@ setup_master(void (*warn)(struct dns_rdatacallbacks *, const char *, ...),
        isc_buffer_setactive(&source, len);
        dns_master_initrawheader(&header);
 
-       result = dns_name_fromtext(dns_origin, &source, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(dns_origin, &source, dns_rootname, 0);
        if (result != ISC_R_SUCCESS) {
                return result;
        }
index a786299a0297c3c3993fb5d1cc52de7491ffb394..0b39ba2fe50aa22badbbd6e045fe5860e50202bf 100644 (file)
@@ -640,7 +640,7 @@ ISC_RUN_TEST_IMPL(isabsolute) {
                dns_name_init(&name);
                isc_buffer_init(&nb, data, BUFSIZ);
                dns_name_setbuffer(&name, &nb);
-               result = dns_name_fromtext(&name, &b, NULL, 0, NULL);
+               result = dns_name_fromtext(&name, &b, NULL, 0);
                assert_int_equal(result, ISC_R_SUCCESS);
 
                assert_int_equal(dns_name_isabsolute(&name),
index e3c693d4a91197d0962d24bfe56e917bbec4f335..7e716bf024d6710ea95c31316964124a43feff36 100644 (file)
@@ -134,12 +134,12 @@ ownercase_test_one(const char *str1, const char *str2) {
 
        isc_buffer_constinit(&b, str1, strlen(str1));
        isc_buffer_add(&b, strlen(str1));
-       result = dns_name_fromtext(name1, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name1, &b, dns_rootname, 0);
        assert_int_equal(result, ISC_R_SUCCESS);
 
        isc_buffer_constinit(&b, str2, strlen(str2));
        isc_buffer_add(&b, strlen(str2));
-       result = dns_name_fromtext(name2, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name2, &b, dns_rootname, 0);
        assert_int_equal(result, ISC_R_SUCCESS);
 
        /* Store the case from name1 */
@@ -206,12 +206,12 @@ ISC_RUN_TEST_IMPL(setownercase) {
 
        isc_buffer_constinit(&b, str1, strlen(str1));
        isc_buffer_add(&b, strlen(str1));
-       result = dns_name_fromtext(name1, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name1, &b, dns_rootname, 0);
        assert_int_equal(result, ISC_R_SUCCESS);
 
        isc_buffer_constinit(&b, str1, strlen(str1));
        isc_buffer_add(&b, strlen(str1));
-       result = dns_name_fromtext(name2, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(name2, &b, dns_rootname, 0);
        assert_int_equal(result, ISC_R_SUCCESS);
 
        assert_false(CASESET(&header));
index c1d44fa3f58d5226c445ffe3831ac3702a8449db..89a347e2e3dfe534bffc6d6dbf9b5203bd85fc53 100644 (file)
@@ -133,7 +133,7 @@ ISC_RUN_TEST_IMPL(isc_rsa_verify) {
        name = dns_fixedname_initname(&fname);
        isc_buffer_constinit(&buf, "rsa.", 4);
        isc_buffer_add(&buf, 4);
-       ret = dns_name_fromtext(name, &buf, NULL, 0, NULL);
+       ret = dns_name_fromtext(name, &buf, NULL, 0);
        assert_int_equal(ret, ISC_R_SUCCESS);
 
        ret = dst_key_fromfile(name, 29238, DST_ALG_RSASHA256, DST_TYPE_PUBLIC,
index a0038c6ddc085766a8e6f54d81255b60b66ae7f3..dbeb4a7cc86f96531df951a494f87d1c07601aac 100644 (file)
@@ -448,7 +448,7 @@ ISC_RUN_TEST_IMPL(skr_read) {
        dname = dns_fixedname_initname(&dfname);
        isc_buffer_init(&b, name, strlen(name));
        isc_buffer_add(&b, strlen(name));
-       result = dns_name_fromtext(dname, &b, dns_rootname, 0, NULL);
+       result = dns_name_fromtext(dname, &b, dns_rootname, 0);
        assert_int_equal(result, ISC_R_SUCCESS);
 
        /* Get the KSK */
index 2ded8b3e3bea3c72acd6f9d9b915e2449cebfbbd..7c88b6f285c81642a6506bdc6c169aeb760b1ad9 100644 (file)
@@ -419,7 +419,7 @@ dns_test_namefromstring(const char *namestr, dns_fixedname_t *fname) {
        isc_buffer_allocate(mctx, &b, length);
 
        isc_buffer_putmem(b, (const unsigned char *)namestr, length);
-       result = dns_name_fromtext(name, b, NULL, 0, NULL);
+       result = dns_name_fromtext(name, b, NULL, 0);
        INSIST(result == ISC_R_SUCCESS);
 
        isc_buffer_free(&b);