]> git.ipfire.org Git - thirdparty/vala.git/commitdiff
vala: Replace if-else-tree with switch
authorRico Tzschichholz <ricotz@ubuntu.com>
Sun, 7 Jan 2018 10:25:03 +0000 (11:25 +0100)
committerRico Tzschichholz <ricotz@ubuntu.com>
Wed, 10 Jan 2018 19:40:35 +0000 (20:40 +0100)
vala/valaassignment.vala

index 761a02e1c0168eab0843cc83f7c67df91b36f29d..1c62fcdc903e9a12817f21a7581ebf894cf6f6b7 100644 (file)
@@ -241,26 +241,17 @@ public class Vala.Assignment : Expression {
                                right.target_type = right.target_type.copy ();
                                right.target_type.value_owned = false;
 
-                               if (operator == AssignmentOperator.BITWISE_OR) {
-                                       bin.operator = BinaryOperator.BITWISE_OR;
-                               } else if (operator == AssignmentOperator.BITWISE_AND) {
-                                       bin.operator = BinaryOperator.BITWISE_AND;
-                               } else if (operator == AssignmentOperator.BITWISE_XOR) {
-                                       bin.operator = BinaryOperator.BITWISE_XOR;
-                               } else if (operator == AssignmentOperator.ADD) {
-                                       bin.operator = BinaryOperator.PLUS;
-                               } else if (operator == AssignmentOperator.SUB) {
-                                       bin.operator = BinaryOperator.MINUS;
-                               } else if (operator == AssignmentOperator.MUL) {
-                                       bin.operator = BinaryOperator.MUL;
-                               } else if (operator == AssignmentOperator.DIV) {
-                                       bin.operator = BinaryOperator.DIV;
-                               } else if (operator == AssignmentOperator.PERCENT) {
-                                       bin.operator = BinaryOperator.MOD;
-                               } else if (operator == AssignmentOperator.SHIFT_LEFT) {
-                                       bin.operator = BinaryOperator.SHIFT_LEFT;
-                               } else if (operator == AssignmentOperator.SHIFT_RIGHT) {
-                                       bin.operator = BinaryOperator.SHIFT_RIGHT;
+                               switch (operator) {
+                               case AssignmentOperator.BITWISE_OR: bin.operator = BinaryOperator.BITWISE_OR; break;
+                               case AssignmentOperator.BITWISE_AND: bin.operator = BinaryOperator.BITWISE_AND; break;
+                               case AssignmentOperator.BITWISE_XOR: bin.operator = BinaryOperator.BITWISE_XOR; break;
+                               case AssignmentOperator.ADD: bin.operator = BinaryOperator.PLUS; break;
+                               case AssignmentOperator.SUB: bin.operator = BinaryOperator.MINUS; break;
+                               case AssignmentOperator.MUL: bin.operator = BinaryOperator.MUL; break;
+                               case AssignmentOperator.DIV: bin.operator = BinaryOperator.DIV; break;
+                               case AssignmentOperator.PERCENT: bin.operator = BinaryOperator.MOD; break;
+                               case AssignmentOperator.SHIFT_LEFT: bin.operator = BinaryOperator.SHIFT_LEFT; break;
+                               case AssignmentOperator.SHIFT_RIGHT: bin.operator = BinaryOperator.SHIFT_RIGHT; break;
                                }
 
                                right = bin;