cindex: only create {-cidx_err} field on failures

We only use it as a boolean flag, and there's no need to waste
space for common, non-error cases.

diff --git a/lib/PublicInbox/CodeSearchIdx.pm b/lib/PublicInbox/CodeSearchIdx.pm
index bd67a57ed97439f825e2861aead50b42b8e1f250..cf6a6efe77ec3dd39a25cc8a5d4c64a74330b9f7 100644 (file)
--- a/lib/PublicInbox/CodeSearchIdx.pm
+++ b/lib/PublicInbox/CodeSearchIdx.pm
@@ -383,8 +383,8 @@ sub git_dir_hash ($) { hex(substr(sha256_hex($_[0]), 0, 8)) }
 sub _cb { # run_await cb
        my ($pid, $cmd, undef, $opt, $cb, $self, $git, @arg) = @_;
        return if $DO_QUIT;
-       ($git->{-cidx_err} = $?) ? warn("W: @$cmd (\$?=$?)\n") :
-                               $cb->($opt, $self, $git, @arg);
+       $? ? ($git->{-cidx_err} = warn("W: @$cmd (\$?=$?)\n")) :
+                       $cb->($opt, $self, $git, @arg);
 }
 
 sub run_git {