Bug 621572: (CVE-2010-4572) [SECURITY] chart.cgi vulnerable to header-injection due...

[r=mkanat a=LpSolit]

diff --git a/chart.cgi b/chart.cgi
index a04cde06829270f84b830c745862f3d606d9a56c..e7a0f5e8bf906ce5c72b4e923192c9a90f5a43bf 100755 (executable)
--- a/chart.cgi
+++ b/chart.cgi
@@ -74,8 +74,8 @@ if (!Bugzilla->feature('new_charts')) {
 # Go back to query.cgi if we are adding a boolean chart parameter.
 if (grep(/^cmd-/, $cgi->param())) {
     my $params = $cgi->canonicalise_query("format", "ctype", "action");
-    print "Location: query.cgi?format=" . $cgi->param('query_format') .
-                                          ($params ? "&$params" : "") . "\n\n";
+    print $cgi->redirect("query.cgi?format=" . $cgi->param('query_format') .
+                                               ($params ? "&$params" : ""));
     exit;
 }
 
@@ -98,7 +98,7 @@ $action ||= "assemble";
 # Go to buglist.cgi if we are doing a search.
 if ($action eq "search") {
     my $params = $cgi->canonicalise_query("format", "ctype", "action");
-    print "Location: buglist.cgi" . ($params ? "?$params" : "") . "\n\n";
+    print $cgi->redirect("buglist.cgi" . ($params ? "?$params" : ""));
     exit;
 }