debugfs: Return error during {full/open}_proxy_open() on rmmod

[ Upstream commit 112cedc8e600b668688eb809bf11817adec58ddc ]

If a kernel module gets unloaded then it printed report about a leak before
commit 275678e7a9be ("debugfs: Check module state before warning in
{full/open}_proxy_open()"). An additional check was added in this commit to
avoid this printing. But it was forgotten that the function must return an
error in this case because it was not actually opened.

As result, the systems started to crash or to hang when a module was
unloaded while something was trying to open a file.

Fixes: 275678e7a9be ("debugfs: Check module state before warning in {full/open}_proxy_open()")
Cc: Taehee Yoo <ap420073@gmail.com>
Reported-by: Mário Lopes <ml@simonwunderlich.de>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Link: https://lore.kernel.org/r/20210802162444.7848-1-sven@narfation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
index 686e0ad287880c15406a479a3acc209a8fa1396f..3aa5eb9ce498e46b89ef40e7cc900378de3bb29a 100644 (file)
--- a/fs/debugfs/file.c
+++ b/fs/debugfs/file.c
@@ -179,8 +179,10 @@ static int open_proxy_open(struct inode *inode, struct file *filp)
        if (!fops_get(real_fops)) {
 #ifdef CONFIG_MODULES
                if (real_fops->owner &&
-                   real_fops->owner->state == MODULE_STATE_GOING)
+                   real_fops->owner->state == MODULE_STATE_GOING) {
+                       r = -ENXIO;
                        goto out;
+               }
 #endif
 
                /* Huh? Module did not clean up after itself at exit? */
@@ -314,8 +316,10 @@ static int full_proxy_open(struct inode *inode, struct file *filp)
        if (!fops_get(real_fops)) {
 #ifdef CONFIG_MODULES
                if (real_fops->owner &&
-                   real_fops->owner->state == MODULE_STATE_GOING)
+                   real_fops->owner->state == MODULE_STATE_GOING) {
+                       r = -ENXIO;
                        goto out;
+               }
 #endif
 
                /* Huh? Module did not cleanup after itself at exit? */