]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: Intel: bytcr_rt5651: Fix MCLK leak on platform_clock_control error
authorAravind Anilraj <aravindanilraj0702@gmail.com>
Wed, 1 Apr 2026 22:05:05 +0000 (18:05 -0400)
committerMark Brown <broonie@kernel.org>
Fri, 3 Apr 2026 14:15:00 +0000 (15:15 +0100)
If byt_rt5651_prepare_and_enable_pll1() fails, the function returns
without calling clk_disable_unprepare() on priv->mclk, which was
already enabled earlier in the same code path. Add the missing
cleanup call to prevent the clock from leaking.

Signed-off-by: Aravind Anilraj <aravindanilraj0702@gmail.com>
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://patch.msgid.link/20260401220507.23557-3-aravindanilraj0702@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/bytcr_rt5651.c

index 68cf463f1d5070a34466d3809a31645b804f0cf5..8932fc5d6f4f256a2f4bbebd776cc1cfa5e5f567 100644 (file)
@@ -209,6 +209,8 @@ static int platform_clock_control(struct snd_soc_dapm_widget *w,
                        return ret;
                }
                ret = byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50);
+               if (ret < 0)
+                       clk_disable_unprepare(priv->mclk);
        } else {
                /*
                 * Set codec clock source to internal clock before