Keep a reference around for the bind task

diff --git a/servers/lloadd/daemon.c b/servers/lloadd/daemon.c
index 3ae3dfca253c82d257f68bb5c6bf9346c7cf85d3..74701351f32026e0aa7cd8e28e0dc2776ea5c2f5 100644 (file)
--- a/servers/lloadd/daemon.c
+++ b/servers/lloadd/daemon.c
@@ -1432,13 +1432,7 @@ backend_conn_cb( ldap_pvt_thread_start_t *start, void *startarg, void *arg )
     LloadBackend *b = arg;
 
     if ( b == NULL || c->c_private == b ) {
-        if ( start == upstream_bind ) {
-            /* FIXME: is upstream_bind safe without a reference of its own? */
-            CONNECTION_LOCK(c);
-        } else {
-            CONNECTION_LOCK_DECREF(c);
-        }
-        CONNECTION_DESTROY(c);
+        CONNECTION_LOCK_DESTROY(c);
         return 1;
     }
     return 0;

diff --git a/servers/lloadd/upstream.c b/servers/lloadd/upstream.c
index 391b609108924036d6fdcace7168f5b78cab8f84..77fc3fd490d89210c300c21c2b0efddfcce16afa 100644 (file)
--- a/servers/lloadd/upstream.c
+++ b/servers/lloadd/upstream.c
@@ -361,7 +361,7 @@ upstream_bind( void *ctx, void *arg )
     BerElement *ber;
     ber_int_t msgid;
 
-    CONNECTION_LOCK(c);
+    CONNECTION_LOCK_DECREF(c);
     c->c_pdu_cb = upstream_bind_cb;
     CONNECTION_UNLOCK_INCREF(c);
 
@@ -460,6 +460,7 @@ upstream_finish( LloadConnection *c )
         b->b_last_conn = c;
     } else {
         rc = 1;
+        c->c_refcnt++;
         ldap_pvt_thread_pool_submit( &connection_pool, upstream_bind, c );
     }