]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
perf sched stats: Add NULL check for cd_map
authorSwapnil Sapkal <swapnil.sapkal@amd.com>
Tue, 27 Jan 2026 18:49:57 +0000 (18:49 +0000)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 28 Jan 2026 18:18:31 +0000 (15:18 -0300)
In perf_sched__schedstat_live(), build_cpu_domain_map() returns the
pointer to cpu_domain_map which can also be NULL.

Add NULL check for the same to avoid NULL pointer dereference.

Fixes: 00093b3133984ffe ("perf sched stats: Add support for live mode")
Reviewed-by: Shrikanth Hegde <sshegde@linux.ibm.com>
Signed-off-by: Swapnil Sapkal <swapnil.sapkal@amd.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Anubhav Shelat <ashelat@redhat.com>
Cc: Chen Yu <yu.c.chen@intel.com>
Cc: Gautham Shenoy <gautham.shenoy@amd.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Thomas Falcon <thomas.falcon@intel.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-sched.c

index b190e928117c582b7fca57109e220551c79cc2d8..f5e449bd682370da138435c72c4cdb10b75b1890 100644 (file)
@@ -4714,6 +4714,11 @@ static int perf_sched__schedstat_live(struct perf_sched *sched,
 
        nr = cpu__max_present_cpu().cpu;
        cd_map = build_cpu_domain_map(&sv, &md, nr);
+       if (!cd_map) {
+               pr_err("Unable to generate cpu-domain relation info");
+               goto out;
+       }
+
        show_schedstat_data(&cpu_head, cd_map, NULL, NULL, false);
        free_cpu_domain_info(cd_map, sv, nr);
 out: