scsi: qla2xxx: Fix erroneous link up failure

commit 5b51f35d127e7bef55fa869d2465e2bca4636454 upstream.

Link up failure occurred where driver failed to see certain events from FW
indicating link up (AEN 8011) and fabric login completion (AEN 8014).
Without these 2 events, driver would not proceed forward to scan the
fabric. The cause of this is due to delay in the receive of interrupt for
Mailbox 60 that causes qla to set the fw_started flag late.  The late
setting of this flag causes other interrupts to be dropped.  These dropped
interrupts happen to be the link up (AEN 8011) and fabric login completion
(AEN 8014).

Set fw_started flag early to prevent interrupts being dropped.

Cc: stable@vger.kernel.org
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20230714070104.40052-6-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index fa14e944f83c8e3bf9abc870021b4aeff9c961af..4105f26f42b3bdeef2ef81f204975ba8189a451d 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -4817,15 +4817,16 @@ qla2x00_init_rings(scsi_qla_host_t *vha)
        if (ha->flags.edif_enabled)
                mid_init_cb->init_cb.frame_payload_size = cpu_to_le16(ELS_MAX_PAYLOAD);
 
+       QLA_FW_STARTED(ha);
        rval = qla2x00_init_firmware(vha, ha->init_cb_size);
 next_check:
        if (rval) {
+               QLA_FW_STOPPED(ha);
                ql_log(ql_log_fatal, vha, 0x00d2,
                    "Init Firmware **** FAILED ****.\n");
        } else {
                ql_dbg(ql_dbg_init, vha, 0x00d3,
                    "Init Firmware -- success.\n");
-               QLA_FW_STARTED(ha);
                vha->u_ql2xexchoffld = vha->u_ql2xiniexchg = 0;
        }
 

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 92790319138e719a6c01e4d80c540a2b0e49cb87..80c2dcf567b0c59aca7a8a8b7baf1c7cc58b87fc 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -1121,8 +1121,12 @@ qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb)
        unsigned long   flags;
        fc_port_t       *fcport = NULL;
 
-       if (!vha->hw->flags.fw_started)
+       if (!vha->hw->flags.fw_started) {
+               ql_log(ql_log_warn, vha, 0x50ff,
+                   "Dropping AEN - %04x %04x %04x %04x.\n",
+                   mb[0], mb[1], mb[2], mb[3]);
                return;
+       }
 
        /* Setup to process RIO completion. */
        handle_cnt = 0;