]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: hisi-kunpeng: Fixed the wrong debugfs node name in hisi_spi debugfs initialization
authorDevyn Liu <liudingyuan@h-partners.com>
Thu, 8 Jan 2026 07:53:23 +0000 (15:53 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 12 Jan 2026 11:20:43 +0000 (11:20 +0000)
In hisi_spi_debugfs_init, spi controller pointer is calculated
by container_of macro, and the member is hs->dev. But the host
cannot be calculated offset directly by this. (hs->dev) points
to (pdev->dev), and it is the (host->dev.parent) rather than
(host->dev) points to the (pdev->dev), which is set in
__spi_alloc_controller.

In this patch, this issues is fixed by getting the spi_controller
data from pdev->dev by dev_get_drvdata() directly. (dev->driver_data)
points to the spi controller data in the probe stage.

Signed-off-by: Devyn Liu <liudingyuan@h-partners.com>
Reviewed-by: Yang Shen <shenyang39@huawei.com>
Link: https://patch.msgid.link/20260108075323.3831574-1-liudingyuan@h-partners.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-hisi-kunpeng.c

index dadf558dd9c0c66bcfa64174a6fcad42dd4b6006..80a1a15de0bc33da1c52c29ece9a6cd06e669de4 100644 (file)
@@ -161,10 +161,8 @@ static const struct debugfs_reg32 hisi_spi_regs[] = {
 static int hisi_spi_debugfs_init(struct hisi_spi *hs)
 {
        char name[32];
+       struct spi_controller *host = dev_get_drvdata(hs->dev);
 
-       struct spi_controller *host;
-
-       host = container_of(hs->dev, struct spi_controller, dev);
        snprintf(name, 32, "hisi_spi%d", host->bus_num);
        hs->debugfs = debugfs_create_dir(name, NULL);
        if (IS_ERR(hs->debugfs))