]> git.ipfire.org Git - thirdparty/knot-dns.git/commitdiff
nitpick in NSEC3 proofs: simplify an assertion
authorVladimír Čunát <vladimir.cunat@nic.cz>
Wed, 1 Aug 2018 16:36:55 +0000 (18:36 +0200)
committerDaniel Salzman <daniel.salzman@nic.cz>
Wed, 1 Aug 2018 18:55:27 +0000 (20:55 +0200)
src/knot/nameserver/nsec_proofs.c

index 9f8f9bcd6231cfa238964de52f42cd40e3870c84..930920b2f72b50bb8961e99e9b4a93dcc55febdc 100644 (file)
@@ -117,17 +117,16 @@ static const zone_node_t *nsec3_encloser(const zone_node_t *closest)
 static const knot_dname_t *get_next_closer(const knot_dname_t *closest_encloser,
                                            const knot_dname_t *name)
 {
+       // make name only one label longer than closest_encloser
        size_t ce_labels = knot_dname_labels(closest_encloser, NULL);
        size_t qname_labels = knot_dname_labels(name, NULL);
-
-       // the common labels should match
-       assert(knot_dname_matched_labels(closest_encloser, name) == ce_labels);
-
-       // chop some labels from the qname
        for (int i = 0; i < (qname_labels - ce_labels - 1); ++i) {
                name = knot_wire_next_label(name, NULL);
        }
 
+       // the common labels should match
+       assert(knot_dname_is_equal(knot_wire_next_label(name, NULL), closest_encloser));
+
        return name;
 }