[#722,!1] Addressed review comments

    Added test to ensure DUID size constant(s) are RFC compliant

diff --git a/src/lib/dhcp/tests/duid_unittest.cc b/src/lib/dhcp/tests/duid_unittest.cc
index 108bbe4d1e71df3e87e8dbc4820f6fdfbfa3a9cd..d9bb7e1014c9cdb81040f795ab07930bd732b533 100644 (file)
--- a/src/lib/dhcp/tests/duid_unittest.cc
+++ b/src/lib/dhcp/tests/duid_unittest.cc
@@ -62,6 +62,10 @@ TEST(DuidTest, constructor) {
 // This test verifies if DUID size restrictions are implemented
 // properly.
 TEST(DuidTest, size) {
+
+    // Ensure that our size constant is RFC-compliant.
+    ASSERT_EQ(128, MAX_DUID_LEN);
+
     uint8_t data[MAX_DUID_LEN + 1];
     vector<uint8_t> data2;
     for (uint8_t i = 0; i < MAX_DUID_LEN + 1; ++i) {
@@ -220,6 +224,9 @@ TEST(ClientIdTest, constructor) {
 
 // Check that client-id sizes are reasonable
 TEST(ClientIdTest, size) {
+    // Ensure that our size constant is RFC-compliant.
+    ASSERT_EQ(128, MAX_CLIENT_ID_LEN);
+
     uint8_t data[MAX_CLIENT_ID_LEN + 1];
     vector<uint8_t> data2;
     for (uint8_t i = 0; i < MAX_CLIENT_ID_LEN + 1; ++i) {