]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
drs_utils: Remove unnecessary qualification
authorJennifer Sutton <jennifersutton@catalyst.net.nz>
Tue, 6 Aug 2024 03:07:44 +0000 (15:07 +1200)
committerJo Sutton <jsutton@samba.org>
Mon, 26 May 2025 02:41:36 +0000 (02:41 +0000)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15852

Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
python/samba/drs_utils.py

index 06e6928e3083ad007a43e84233c6b5ca0e276ef8..6142349be891595762c9cc6de94679f6783a774b 100644 (file)
@@ -23,7 +23,7 @@ from samba.ndr import ndr_unpack
 from samba import dsdb
 from samba import werror
 from samba import WERRORError
-import samba
+
 import ldb
 from samba.dcerpc.drsuapi import (DRSUAPI_ATTID_name,
                                   DRSUAPI_SUPPORTED_EXTENSION_GETCHGREQ_V8,
@@ -158,12 +158,12 @@ def drs_get_rodc_partial_attribute_set(samdb):
         ldap_display_name = str(r["lDAPDisplayName"][0])
         if "systemFlags" in r:
             system_flags      = r["systemFlags"][0]
-            if (int(system_flags) & (samba.dsdb.DS_FLAG_ATTR_NOT_REPLICATED |
-                                     samba.dsdb.DS_FLAG_ATTR_IS_CONSTRUCTED)):
+            if (int(system_flags) & (dsdb.DS_FLAG_ATTR_NOT_REPLICATED |
+                                     dsdb.DS_FLAG_ATTR_IS_CONSTRUCTED)):
                 continue
         if "searchFlags" in r:
             search_flags = r["searchFlags"][0]
-            if (int(search_flags) & samba.dsdb.SEARCH_FLAG_RODC_ATTRIBUTE):
+            if (int(search_flags) & dsdb.SEARCH_FLAG_RODC_ATTRIBUTE):
                 continue
         attid = samdb.get_attid_from_lDAPDisplayName(ldap_display_name)
         attids.append(int(attid))