]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
pool: avoid possible double free in error path
authorVictor Julien <victor@inliniac.net>
Thu, 25 Oct 2018 09:44:53 +0000 (11:44 +0200)
committerVictor Julien <victor@inliniac.net>
Thu, 1 Nov 2018 14:46:10 +0000 (15:46 +0100)
Should be impossible as a double free, but scan-build-7 thinks it
is possible.

src/util-pool.c

index 3b5792e798550d7955ee64723cbe14333ff21298..c88cc847cba94447d9020adaf5dcd3e53f9343be 100644 (file)
@@ -197,6 +197,7 @@ Pool *PoolInit(uint32_t size, uint32_t prealloc_size, uint32_t elt_size,
                 SCLogError(SC_ERR_POOL_INIT, "init error");
                 if (p->Cleanup)
                     p->Cleanup(pb->data);
+                pb->data = NULL;
                 goto error;
             }